Date: Sun, 5 Jan 2025 10:42:20 -0700 From: Warner Losh <imp@bsdimp.com> To: Ronald Klop <ronald-lists@klop.ws> Cc: Dennis Clarke <dclarke@blastwave.org>, Current FreeBSD <freebsd-current@freebsd.org> Subject: Re: Is there any way to nudge security/libfido2? It blocks chunks of KDE Message-ID: <CANCZdfq3gqpXa=s4n_=e=-NCZ7SJV8su24n=%2BaJ444UVk5BNMQ@mail.gmail.com> In-Reply-To: <1645708192.12009.1736073795989@localhost> References: <36c212cc-0da9-43b7-b760-d29d71bc35e5@blastwave.org> <1645708192.12009.1736073795989@localhost>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sun, Jan 5, 2025, 3:43 AM Ronald Klop <ronald-lists@klop.ws> wrote: > > *Van:* Dennis Clarke <dclarke@blastwave.org> > *Datum:* zondag, 5 januari 2025 06:45l > *Aan:* Current FreeBSD <freebsd-current@freebsd.org> > *Onderwerp:* Is there any way to nudge security/libfido2? It blocks > chunks of KDE > > > It seems to have been a while since I was able to run a poudriere > bulk build and get KDE available. At least on 15-CURRENT. There is a > little brick in the path called security/libfido2 : > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283697 > > commit 74ecdf86d8d2a94a4bfcf094a2e21b4747e4907f resulted in the > appropriate declarations for the correct versions of _POSIX_C_SOURCE > via __POSIX_VISIBLE and then we get > > error: call to undeclared function 'ppoll'; ISO C99 and later do not > support implicit function declarations > [-Werror,-Wimplicit-function-declaration] > > > Sort of annoying as even 14.2-RELEASE on amd64 and ports 2024Q4 fails : > > [142amd64-2024Q4] [2025-01-04_10h11m35s] [committing] Queued: 5 Built: 4 > Failed: 1 Skipped: 0 Ignored: 0 Fetched: 0 Tobuild: 0 Time: 00:04:44 > > The 15.0-CURRENT is much much worse : > > [150amd64-latest] [2025-01-04_08h12m11s] [committing] Queued: 365 Built: > 323 Failed: 2 Skipped: 40 Ignored: 0 Fetched: 0 Tobuild: 0 Time: > 01:52:01 > > > In any case ... is there a way to nudge that ? > > -- > -- > Dennis Clarke > RISC-V/SPARC/PPC/ARM/CISC > UNIX and Linux spoken > > ------------------------------ > > > > Hi, > > The issue is assigned and the port has an active maintainer so that looks > good. > I see you replied on the issue with a patch for a solution, but the patch > is hidden in quite a large comment (I needed to read it twice before I > spotted it). It can help to put the patch in an attachment of the issue as > type 'patch'. > You can send an email to ports@freebsd.org to get the attention of the > ports managers. > It can also help to open an upstream issue on the github repo of libfido. > If the patch is accepted there it is a good argument to get the patch into > FreeBSD. > > NB: I understand your feeling of urgency in this. In the meantime this is > also a period of holidays/weekend, etc. > Yes. The port can't define __BSD_VISIBLE directly. That's bogus. Also both _POSIX_C_SORCE and _BSD_SOURCE is bogus. The solution is super simple: just don't define POSIX_C_SOURCE since you are obviously trying to use something that's not defined in the version of POSIX you are requesting the strict namespace for. Warner Hope this helps. > > Regards, > Ronald. > > [-- Attachment #2 --] <div dir="ltr"><div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Jan 5, 2025, 3:43 AM Ronald Klop <<a href="mailto:ronald-lists@klop.ws" target="_blank">ronald-lists@klop.ws</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><br> <p><strong>Van:</strong> Dennis Clarke <<a href="mailto:dclarke@blastwave.org" rel="noreferrer" target="_blank">dclarke@blastwave.org</a>><br> <strong>Datum:</strong> zondag, 5 januari 2025 06:45l<br> <strong>Aan:</strong> Current FreeBSD <<a href="mailto:freebsd-current@freebsd.org" rel="noreferrer" target="_blank">freebsd-current@freebsd.org</a>><br> <strong>Onderwerp:</strong> Is there any way to nudge security/libfido2? It blocks chunks of KDE</p> <blockquote style="padding-right:0px;padding-left:5px;margin-left:5px;border-left:#000000 2px solid;margin-right:0px"> <div id="m_5497418980586631360m_4974479658887602259P"> <div id="m_5497418980586631360m_4974479658887602259P.P"><br> It seems to have been a while since I was able to run a poudriere bulk build and get KDE available. At least on 15-CURRENT. There is a<br> little brick in the path called security/libfido2 :<br> <br> <a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283697" rel="noreferrer" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283697</a><br>; <br> commit 74ecdf86d8d2a94a4bfcf094a2e21b4747e4907f resulted in the<br> appropriate declarations for the correct versions of _POSIX_C_SOURCE<br> via __POSIX_VISIBLE and then we get<br> <br> error: call to undeclared function 'ppoll'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]<br> <br> <br> Sort of annoying as even 14.2-RELEASE on amd64 and ports 2024Q4 fails :<br> <br> [142amd64-2024Q4] [2025-01-04_10h11m35s] [committing] Queued: 5 Built: 4 Failed: 1 Skipped: 0 Ignored: 0 Fetched: 0 Tobuild: 0 Time: 00:04:44<br> <br> The 15.0-CURRENT is much much worse :<br> <br> [150amd64-latest] [2025-01-04_08h12m11s] [committing] Queued: 365 Built: 323 Failed: 2 Skipped: 40 Ignored: 0 Fetched: 0 Tobuild: 0 Time: 01:52:01<br> <br> <br> In any case ... is there a way to nudge that ?<br> <br> -- <br> --<br> Dennis Clarke<br> RISC-V/SPARC/PPC/ARM/CISC<br> UNIX and Linux spoken<br> </div> <hr></div> </blockquote> <br> <br> Hi,<br> <br> The issue is assigned and the port has an active maintainer so that looks good.<br> I see you replied on the issue with a patch for a solution, but the patch is hidden in quite a large comment (I needed to read it twice before I spotted it). It can help to put the patch in an attachment of the issue as type 'patch'.<br> You can send an email to <a href="mailto:ports@freebsd.org" rel="noreferrer" target="_blank">ports@freebsd.org</a> to get the attention of the ports managers.<br> It can also help to open an upstream issue on the github repo of libfido. If the patch is accepted there it is a good argument to get the patch into FreeBSD.<br> <br> NB: I understand your feeling of urgency in this. In the meantime this is also a period of holidays/weekend, etc.<br></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Yes. The port can't define __BSD_VISIBLE directly. That's bogus. Also both _POSIX_C_SORCE and _BSD_SOURCE is bogus. The solution is super simple: just don't define POSIX_C_SOURCE since you are obviously trying to use something that's not defined in the version of POSIX you are requesting the strict namespace for.</div><div dir="auto"><br></div><div>Warner</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div> Hope this helps.<br> <br> Regards,<br> Ronald.<br> </div></blockquote></div></div></div> </div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfq3gqpXa=s4n_=e=-NCZ7SJV8su24n=%2BaJ444UVk5BNMQ>