Date: Thu, 16 Jan 1997 21:54:30 +0100 From: j@uriah.heep.sax.de (J Wunsch) To: thompson@tgsoft.com (mark thompson) Cc: jkh@time.cdrom.com, freebsd-bugs@freefall.freebsd.org Subject: Re: bin/2493: make $DESTDIR work Message-ID: <Mutt.19970116215430.j@uriah.heep.sax.de> In-Reply-To: <199701151334.FAA21208@squirrel.tgsoft.com>; from mark thompson on Jan 15, 1997 05:34:49 -0800 References: <21415.853307483@time.cdrom.com> <199701151334.FAA21208@squirrel.tgsoft.com>
next in thread | previous in thread | raw e-mail | index | archive | help
As mark thompson wrote: > You will recall that when i raised this whole business week or so ago, > you suggested that whatever patch i had might be more useful as an > example than something to actually use. In the event, some of the > changes are "obviously" ok, and, sadly several are not so obvious. > Furthermore, the games subdirectory still has a problem or two (i know > that there are at least some malloc faux-pas). > I leave it to the judgement of the court. Well, i've only heard one objection, that was: ``Name this thing TARGETDIR.'' What about this? I would kindly ask you to also do one final test: run a ``make release'' (i hope you've got the disk space and the CVS tree for this). This is one of the occasions where ${DESTDIR} is exploitet regularly (perhaps the only occasion in the entire FreeBSD tree). If your changes broke the existing ${DESTDIR} behaviour, this should pop up there. If it doesn't break anything, i see no reason to not include it. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Mutt.19970116215430.j>