Date: Tue, 25 Aug 1998 10:13:40 +0100 (BST) From: Doug Rabson <dfr@nlsystems.com> To: "John S. Dyson" <dyson@iquest.net> Cc: current@FreeBSD.ORG Subject: Re: Serious bug in vm_page.h in current Message-ID: <Pine.BSF.4.01.9808251011480.17263-100000@herring.nlsystems.com> In-Reply-To: <199808250841.DAA00455@dyson.iquest.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 25 Aug 1998, John S. Dyson wrote: > Doug Rabson said: > > On Tue, 25 Aug 1998, John S. Dyson wrote: > > > > > > > > PAGE_BUSY is used to set the busy flag, and not the busy > > > bitmask. Attachment contains patch. > > > > I thought of setting the busy flag when I put PAGE_BUSY in but none of the > > places where I changed m->busy++ to PAGE_BUSY(m) set the flag. I'll fix > > it anyway, thanks.. > > > After more careful (and less confused review), your code is correct. The > change in definition isn't that big a deal (only a little confusing when > I was trying to merge some older code in -- and being in a hurry :-)). Likewise, I just read your old patch and understand the confusion. You could set the PG_BUSY flag with PAGE_SET_FLAG(m, PG_BUSY) which uses the new atomic access macros and will be safer on the alpha. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 Fax: +44 181 381 1039 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.01.9808251011480.17263-100000>