Date: Fri, 10 Apr 2020 20:37:16 -0700 From: Neel Chauhan <neel@neelc.org> To: lev@freebsd.org Cc: "Andrey V. Elsukov" <bu7cher@yandex.ru>, "Rodney W. Grimes" <freebsd-rwg@gndrsh.dnsmgr.net>, freebsd-hackers@freebsd.org Subject: Re: Committing one ipfw(8) userland patch Message-ID: <ef964fcb8f3f8671fbef5486a13a1163@neelc.org> In-Reply-To: <1bc864df-0b09-fad4-3781-d7975c385b0e@FreeBSD.org> References: <202004071735.037HZ1mK093414@gndrsh.dnsmgr.net> <7284239b-e335-b219-b28a-386f0edd4f8e@yandex.ru> <1bc864df-0b09-fad4-3781-d7975c385b0e@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thank you all for your feedback. Using the same Phabricator revision here: https://reviews.freebsd.org/D24234 I have added the src-ip4/dst-ip4 and src-ipv4/dst-ipv4 specifiers and made src-ip/dst-ip dual-stack, to be consistent with me/me4/me6 described in this thread. Could you all please give your opinions on it? -Neel On 2020-04-10 04:10, Lev Serebryakov wrote: > On 10.04.2020 13:46, Andrey V. Elsukov wrote: > >> On 07.04.2020 20:35, Rodney W. Grimes wrote: >>> But that is not what this review does. I would be in support of >>> changing the "official" names to src-ip4/dst-ip4/src-ip6/dst-ip6 >>> and making src-ip/dst-ip a backwards compatible alias. >> >> I also think this idea sounds better. > > +1
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ef964fcb8f3f8671fbef5486a13a1163>