Date: Mon, 9 Jul 2018 08:49:35 +0000 From: Brooks Davis <brooks@freebsd.org> To: John Baldwin <jhb@FreeBSD.org> Cc: Brooks Davis <brooks@FreeBSD.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r336023 - in head/sys: kern netinet Message-ID: <20180709084935.GA85898@spindle.one-eyed-alien.net> In-Reply-To: <1e5035b3-3b4e-9095-50b9-6fed7be0181e@FreeBSD.org> References: <201807061003.w66A3X6Z082209@repo.freebsd.org> <1e5035b3-3b4e-9095-50b9-6fed7be0181e@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--zhXaljGHf11kAtnf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 06, 2018 at 09:24:22AM -0700, John Baldwin wrote: > On 7/6/18 3:03 AM, Brooks Davis wrote: > > Author: brooks > > Date: Fri Jul 6 10:03:33 2018 > > New Revision: 336023 > > URL: https://svnweb.freebsd.org/changeset/base/336023 > >=20 > > Log: > > Correct breakage on 32-bit platforms from r335979. >=20 > Do we still need the kvaddr_t casts after the uintptr_t cast? Are those > only required for CHERI (and perhaps if we change the default of how > uintptr_t gets converted to an int to default to the vaddr we may find > we won't need them at all even on CHERI)? The kvaddr_t casts are probably unnecessicary on FreeBSD. I'll look at removing them. The uintptr_t casts are currently harmless on CHERI in hybrid mode and broken in pure-capbiltiy mode until we change uintptr_t cast behavior. -- Brooks --zhXaljGHf11kAtnf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJbQyGeAAoJEKzQXbSebgfAzn0H+weX1F7OjikL74LM0Se+Ek4+ oWgqtAV9cpCPeLYtS6g0Bj8r7Jv17wQmhrHSo2Y9EwOLjRmmUIEJeagOg0RQ1+KR vOgRvslprZE8FyfFAUFZkojUNAQWiX0D0EZydFSIzEGHIAgyzA68IodnXnK6c/eD slDGPTBOKSCvGNQn/WSqFyVdd5eh5Ijy+rp6hdoPIQssElKBC+9bdmDT3TSlaL59 +qd6wFK301ZNSZQN4hRqCcXBUObAvMy9yUP3+zN8f/OYOpxf+bqSKfgb7CkYEZOJ DnlaA0EUjgXMEQwPusTKb42TiVlHXxYKYwVFkfrsikPtBwEKG2FYifwgBfWEEfk= =sZZI -----END PGP SIGNATURE----- --zhXaljGHf11kAtnf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180709084935.GA85898>