Date: Tue, 23 Dec 2003 16:06:51 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Nate Lawson <nate@root.org> Cc: acpi-jp@jp.freebsd.org Subject: RE: acpi_toshiba and acpi_asus drivers Message-ID: <XFMail.20031223160651.jhb@FreeBSD.org> In-Reply-To: <20031223125146.K92457@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23-Dec-2003 Nate Lawson wrote: > On Thu, 18 Dec 2003, John Baldwin wrote: >> On 18-Dec-2003 Nate Lawson wrote: >> > I'm prepping/reworking some user-submitted drivers for import. I'd like >> > some comments on the directory structure. The hardware both drive is >> > everything from fans to hotkeys to lcd backlight. Both are very >> > hw-specific and do not conform to the ACPI spec although they do control >> > their functions through ACPI. >> > >> > The directory structure I'm currently working with is: >> > sys/i386/acpica/acpi_toshiba.c >> > sys/i386/acpica/acpi_asus.c >> > sys/modules/acpi_toshiba/Makefile >> > sys/modules/acpi_asus/Makefile >> > share/man/man4/acpi_toshiba.4 >> > share/man/man4/acpi_asus.4 >> > >> > One alternative is to their modules under the acpi dir (e.g., >> > sys/modules/acpi/acpi_toshiba). Also, the driver src could be >> > sys/dev/acpi_toshiba. However, a new dir for just one file seems a bit >> > much. My main concern is that as these drivers proliferate that we keep >> > the dir structure neat. >> >> Having a /sys/modules/acpi with acpi, acpi_toshiba, and acpi_asus in >> them is probably a good idea. Putting the files under sys/i386/acpica >> is also probably ok. Should the manpages be in man4.i386 rather than >> man4 though? > > Ok, this is what I'll be committing: > sys/i386/acpica/acpi_toshiba.c > sys/i386/acpica/acpi_asus.c > sys/modules/acpi/acpi/Makefile > sys/modules/acpi/acpi_toshiba/Makefile > sys/modules/acpi/acpi_asus/Makefile > share/man/man4.i386/acpi_toshiba.4 > share/man/man4.i386/acpi_asus.4 Sounds good to me, go for it. :) -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20031223160651.jhb>