Date: Wed, 02 Jun 2004 09:54:53 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: John Baldwin <jhb@FreeBSD.org> Cc: current@FreeBSD.org Subject: Re: boot2 patch, please test. Message-ID: <14854.1086162893@critter.freebsd.dk> In-Reply-To: Your message of "Tue, 01 Jun 2004 11:25:02 EDT." <200406011125.03166.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200406011125.03166.jhb@FreeBSD.org>, John Baldwin writes: >On Saturday 29 May 2004 05:21 pm, Poul-Henning Kamp wrote: >> Some embedded boxes do not have the keyboard controller, and this >> patch adds a timeout so they do not get stuck waiting for it to >> become ready. >> >> Please test that this patch does not have any effect on normal >> PC architecture machines. > >I'd prefer that you explicitly set %cx to a timeout value after the cli >instead of relying on its value being zero in the caller. ENOMOREBYTES :-( I guess the logical thing would be to inline it rather than have it be a function, that saves the cx initializtion, the call and the return. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14854.1086162893>