Date: Wed, 4 May 2005 20:29:30 -0400 From: David Schultz <das@FreeBSD.ORG> To: Marc Olzheim <marcolz@stack.nl> Cc: freebsd-threads@FreeBSD.ORG Subject: Re: Floating point exceptions with -pthread Message-ID: <20050505002930.GA23253@VARK.MIT.EDU> In-Reply-To: <20050504233925.GA3436@stack.nl> References: <20050504205745.GH76171@stack.nl> <Pine.GSO.4.43.0505041741310.498-100000@sea.ntplx.net> <20050504221825.GA22732@VARK.MIT.EDU> <20050504233925.GA3436@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 05, 2005, Marc Olzheim wrote:
> On Wed, May 04, 2005 at 06:18:25PM -0400, David Schultz wrote:
> > Yeah, that part is fine. The one odd thing I notice as a glance
> > back at the code is that it uses -12(%ebp) and -16(%ebp) for
> > temporary storage, instead of using -4(%ebp) and -8(%ebp) like
> > the double versions. That's probably a cut-and-pasto on my
> > part.
>
> *doh*
>
> NetBSD cvsweb /usr/src/lib/libm/arch/i387/s_floorf.S:
>
> -----8<---------8<-----------8<-----
> Revision 1.3.16.1 / (download) - annotate - [select for diffs], Thu Mar 28 22:55:09 2002 UTC (3 years, 1 month ago) by he
> Branch: netbsd-1-5
> CVS Tags: netbsd-1-5-PATCH003
> Changes since 1.3: +6 -6 lines
> Diff to previous 1.3 (colored) next main 1.4 (colored)
>
> Pull up revision 1.5 (requested by fvdl):
> Fix stack usage so that a signal delivered in ceil() or floor()
> no longer corrupts the stack.
> -----8<---------8<-----------8<-----
>
> Versions before it looked an awful lot like the one we just fixed. :-/
>
> It seems as though a look into the other NetBSD patches might be
> worthwile...
Heh, guess what version I imported?
/* RCSID("$NetBSD: s_floorf.S,v 1.3 1995/05/09 00:04:32 jtc Exp $") */
Well, I'm glad that at least *I* didn't write it. ;-) I'm really
swamped right now due to the confluence of several deadlines, but
I'll import the fix as soon as I get a free moment. (Anyone else
is welcome to preempt me...)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050505002930.GA23253>