Date: Fri, 5 May 2006 08:39:41 +0200 From: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr> To: Jean-Baptiste Quenot <jbq@caraldi.com> Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/96659: [PATCH] devel/maven: Improve launcher shell script Message-ID: <20060505063941.GA52984@arabica.esil.univ-mrs.fr> In-Reply-To: <20060504091154.GD68374@vision.anyware> References: <200605021342.k42DgUdx059526@freefall.freebsd.org> <20060504091154.GD68374@vision.anyware>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 04, 2006 at 11:11:55AM +0200, Jean-Baptiste Quenot wrote:
> Patch approved working! But I wouldn't have forked the shell
> script... this will be difficult to maintain when changes come
> from upstreams.
I just thought there were too many changes do apply to the original
launcher and too much unused code (cygwin/MacOS stuff) that we could
have our own one.
But in case you prefer to stay with the original launcher, maybe we
could consider another approach by having the default JAVA_HOME,
MAVEN_OPTS and MAVEN_HOME set via /etc/mavenrc (although I would prefer
${PREFIX}/etc/mavenrc in such case)...
Herve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060505063941.GA52984>