Date: Mon, 22 Mar 2010 20:46:53 +0100 (CET) From: Alexander Best <alexbestms@wwu.de> To: John Baldwin <jhb@freebsd.org>, <freebsd-hackers@freebsd.org> Subject: Re: [patch] somebody please fix this outstanding mmap(2) bug Message-ID: <permail-201003221946531e86ffa800005027-a_best01@message-id.uni-muenster.de> In-Reply-To: <201003221329.55369.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin schrieb am 2010-03-22: > On Monday 22 March 2010 11:07:43 am Alexander Best wrote: > > could somebody please commit this patch? it's been around forever > > (2003 or > > 2004) and fixes mmap so the offset argument is being ignored when > > MAP_ANON > is > > defined (just like the mmap(2) manual says). right now the offset > > argument > is > > being taken into account although MAP_ANON is set!!! > > the pr is kern/71258 (including a little c app to demonstrate the > > bug) > > i've also sent a followup patch to the pr which returns EINVAL if > > the offset > > is non zero and MAP_ANON is set, but i guess that might break some > > code. > I think we should go the EINVAL route, and I will commit the patch > you did to > add that. thanks. :) i've checked what posix sais about this and since it doesn't know MAP_ANON there's no real rule for this case. the only thing that comes close is: "The mmap() function may fail if: [EINVAL] The addr argument (if MAP_FIXED was specified) or off is not a multiple of the page size as returned by sysconf(), or is considered invalid by the implementation." -- Alexander Best
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?permail-201003221946531e86ffa800005027-a_best01>