Date: Thu, 12 Apr 2012 08:20:02 +0200 From: Matthias Andree <mandree@FreeBSD.org> To: ports-committers@FreeBSD.org Cc: cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/lang/lua Makefile Message-ID: <4F867412.9030704@FreeBSD.org> In-Reply-To: <201204112121.q3BLL4Fd052917@repoman.freebsd.org> References: <201204112121.q3BLL4Fd052917@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 11.04.2012 23:21, schrieb Matthias Andree: > mandree 2012-04-11 21:21:04 UTC > > FreeBSD ports repository > > Modified files: > lang/lua Makefile > Log: > Add explanatory comment about butchering __MAKE_CONF. > > Revision Changes Path > 1.53 +3 -0 ports/lang/lua/Makefile And no, I don't want to patch Lua's own Makefile with CFLAGS if I can avoid it getting stomped over by our reading /etc/make.conf thrice. I know we can patch CFLAGS that, but it has its own downsides. Re-reading of /etc/make.conf is the harmful part, and we need to stop doing that -- unless someone can come up with a valid reason why variables assigned with = in /etc/make.conf (such as CFLAGS=-O3 -pipe) need to stomp over variables deep in recursive make structures... Related thoughts at http://wiki.freebsd.org/MatthiasAndree/LuaLessonsLearnt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F867412.9030704>