Date: Thu, 2 Aug 2012 21:28:26 +0100 From: Attilio Rao <attilio@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: "freebsd-stable@freebsd.org" <freebsd-stable@freebsd.org>, Sean Bruno <seanbru@yahoo-inc.com> Subject: Re: [stable 9] panic on reboot: ipmi_wd_event() Message-ID: <CAJ-FndBe%2BCXzsBO_rjvGbWJbnDH3rvGnPmrMQe5wxiSoUemQPw@mail.gmail.com> In-Reply-To: <201208020951.19565.jhb@freebsd.org> References: <1342742294.2656.24.camel@powernoodle.corp.yahoo.com> <201208010853.11447.jhb@freebsd.org> <1343861328.5229.6.camel@powernoodle.corp.yahoo.com> <201208020951.19565.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/2/12, John Baldwin <jhb@freebsd.org> wrote:
> On Wednesday, August 01, 2012 6:48:48 pm Sean Bruno wrote:
>> On Wed, 2012-08-01 at 05:53 -0700, John Baldwin wrote:
>> > Index: vfs_subr.c
>> > ===================================================================
>> > --- vfs_subr.c (revision 238969)
>> > +++ vfs_subr.c (working copy)
>> > @@ -1868,8 +1868,11 @@ sched_sync(void)
>> > continue;
>> > }
>> >
>> > - if (first_printf == 0)
>> > + if (first_printf == 0) {
>> > + mtx_unlock(&sync_mtx);
>> > wdog_kern_pat(WD_LASTVAL);
>> > + mtx_lock(&sync_mtx);
>> > + }
>> >
>> > }
>> > if (!LIST_EMPTY(gslp)) {
>> >
>> >
>> > --
>> > John Baldwin
>>
>> This definitely makes the panic go away on reboot.
>
> Attilio, does this change seem ok to you?
Thanks for asking me to review.
I think it is safe because we are going to use LIST_EMPTY() on the
global list anyway as next check.
Attilio
--
Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndBe%2BCXzsBO_rjvGbWJbnDH3rvGnPmrMQe5wxiSoUemQPw>