Date: Thu, 30 Aug 2012 20:54:08 +0200 From: Olli Hauer <ohauer@FreeBSD.org> To: "apache@FreeBSD.org" <apache@FreeBSD.org> Cc: Jason Helfman <jgh@FreeBSD.org> Subject: Re: apache-2.2.22_6 question Message-ID: <503FB6D0.5050302@FreeBSD.org> In-Reply-To: <20120830183648.GA36263@dormouse.experts-exchange.com> References: <20120830174029.GM63706@dormouse.experts-exchange.com> <503FAE12.8070201@FreeBSD.org> <503FB2A2.7080007@gmx.de> <20120830183648.GA36263@dormouse.experts-exchange.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-08-30 20:36, Jason Helfman wrote: > On Thu, Aug 30, 2012 at 08:36:18PM +0200, olli hauer thus spake: >> On 2012-08-30 20:16, Olli Hauer wrote: >>> On 2012-08-30 19:40, Jason Helfman wrote: >>>> Hi, >>>> >>>> I was wondering what implications there are of building apache-2.2.22_6 >>>> against pcre version of 8.02? >>>> >>>> I believe a patch addressed a deprecated function of pcre, however at the >>>> moment I am unable to update a snapshotted portstree to a current >>>> version, or even move to a newer tree. >>>> >>>> I don't know if it would build with that patch, or without the patch, and if >>>> that would be good, or not, and what implications there may be as a result. >>>> >>>> Many Thanks! >>>> >>>> -jgh >>>> >>> >>> Hi Jason, >>> >>> exact, the bump and patch was done because pcre removed a (long) deprecated function. >>> pcre-8.02 will full support the patch because the new api was in this version already >>> the default. >>> >>> file pcre-8.02/pcreposix.c (around line 265) >>> -------------------------------------------- >>> preg->re_nsub = pcre_info((const pcre *)preg->re_pcre, NULL, NULL); >>> return 0; >>> } >>> >>> >>> apache22/files/files/patch-server__util_pcre.c >>> ---------------------------------------------- >>> -preg->re_nsub = pcre_info((const pcre *)preg->re_pcre, NULL, NULL); >>> +pcre_fullinfo((const pcre *)preg->re_pcre, NULL, >>> + PCRE_INFO_CAPTURECOUNT, &(preg->re_nsub)); >>> >>> >> >> Ups, pcre_info != pcre_fullinfo. >> >> But pcre_fullinfo is already in 8.02 present, so I assume it will work with the patch. > > Is there any testing that we can do that would verify this? Perhaps doing > any particular tests that would exercise the regular expression library? > I'm not aware of any test, maybe mm@ (has done the pcre update and written the patch) knows if there is any impact with/without the patch and pcre-8.02 -- Regards, olli
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?503FB6D0.5050302>