Date: Mon, 27 May 2013 10:36:01 -0700 From: Tim Kientzle <kientzle@freebsd.org> To: Andrew Turner <andrew@fubar.geek.nz> Cc: freebsd-arm <freebsd-arm@freebsd.org> Subject: Re: Git crash on EABI system. Message-ID: <9A966CAF-AA93-4553-A718-C59EFF114785@freebsd.org> In-Reply-To: <20130527103114.3fbb00fb@bender.Home> References: <A44A52E5-E878-45CD-B032-F111E5E244BA@freebsd.org> <51949698.80205@thieprojects.ch> <2290084B-D302-4489-BB01-817497901E2B@freebsd.org> <20130527103114.3fbb00fb@bender.Home>
index | next in thread | previous in thread | raw e-mail
On May 27, 2013, at 2:31 AM, Andrew Turner wrote: > On Thu, 16 May 2013 05:04:29 -0400 > Tim Kientzle <kientzle@freebsd.org> wrote: > >> >> On May 16, 2013, at 4:19 AM, Werner Thie wrote: >> >>>> Has anyone else seen this from git on a clang/EABI system? >>>> >>>> Assertion failed: (attr_stack->origin), function >>>> prepare_attr_stack, file attr.c, line 630. >>>> >>>> Program received signal SIGABRT, Aborted. >>>> [Switching to Thread 20c03300 (LWP 100076/git)] >>>> 0x204b842c in thr_kill () from /lib/libc.so.7 >>>> (gdb) bt >>>> #0 0x204b842c in thr_kill () from /lib/libc.so.7 >>>> #1 0x2044157c in raise () from /lib/libthr.so.3 >>>> #2 0x20598130 in abort () from /lib/libc.so.7 >>>> #3 0x20574630 in __assert () from /lib/libc.so.7 >>>> #4 0x00076b28 in ?? () >>>> >>>> I'm planning to do a debug build and see if I can track down any >>>> more details. >>> >>> Hi Tim >>> >>> just built git out of curiosity after your post on the BBone >>> >>> FreeBSD beaglebone 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r250144M: >>> Sat May 4 14:18:20 CEST 2013 >>> root@xtools:/usr/home/wthie/proj/crochet-freebsd/work/obj/arm.armv6/usr/local/src/sys/BEAGLEBONE-NOWITNESS >>> arm >>> >>> git crashes exactly as advertised when cloning a project in >>> >>> Assertion failed: (attr_stack->origin), function >>> prepare_attr_stack, file attr.c, line 630. >> >> Thanks for verifying that. >> >> Unfortunately, a debug build (make -DWITH_DEBUG) does >> not crash for me. So I clearly have more work ahead of me >> to narrow this down. > > Hello Tim, > > Can you test the attached patch for llvm. It should fix git to not > crash. The patch is llvm r180609 [1]. > > The issue was llvm failed to correctly account for pre-indexed > loads/stores. It would then use a subtraction to get the correct > address of the last slash however it used the wrong subtract > instruction. > > Andrew > > [1] http://llvm.org/viewvc/llvm-project?view=revision&revision=180609<llvm_180609.diff>; Starting a new image build with your patch now. I probably won't get a chance to build git and test until tomorrow at least. Timhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9A966CAF-AA93-4553-A718-C59EFF114785>