Date: Thu, 12 Jun 2014 17:53:47 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Jilles Tjoelker <jilles@stack.nl> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Re: [PATCH v2] convert /bin/sh tests over to ATF Message-ID: <CAGHfRMAOK7ccth%2B3VbpCputnxsMTnp-8JtUmw=QovRhehK=toA@mail.gmail.com> In-Reply-To: <20140511153203.GA81002@stack.nl> References: <B5290C1B-F262-479C-8D4F-A5D8B3CE5A52@gmail.com> <20140124162759.GB90996@stack.nl> <CADyfeQUfxi43A4aXg%2Bdu1oGkQAjJFYH1CCXSSoaLKz8nX2hapw@mail.gmail.com> <0A68C9FE-6A3A-4DCF-92A9-A506D7581D69@gmail.com> <96373EF8-77EA-4AA6-8422-63881C32E455@gmail.com> <CAFY7cWCBGmZA1GdSNwNPcSeu_vLTHkSs0aMk3sb6sMs2H-Gn8Q@mail.gmail.com> <CAGHfRMBvawY9_%2BYDAeMhVYftW0gNG6ZKZ2i1dL0a0xb-6hMocg@mail.gmail.com> <CAFY7cWCQKVuvSTNN7issLCHXWcuNPsysk38yLDzcMpkKy5EJ_w@mail.gmail.com> <CAGHfRMApcpwKDnE0DQem_LbfwfhJ%2BZemg38gObAUc=bd3Xup1A@mail.gmail.com> <20140511153203.GA81002@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 11, 2014 at 8:32 AM, Jilles Tjoelker <jilles@stack.nl> wrote: ... > This is OK with me as long as important use cases for me are not broken: > > 1. Allow running new tests on a potentially broken new sh without > installing anything. This used to be possible using 'make regress' in > src/bin/sh/ but this was removed. I now use > SH=$PWD/obj/sh sh tests/legacy_test.sh > (I have an obj/ subdirectory to make the built objects more easily > accessible). > This should also work on stable/9 although it is acceptable to need a > few local hacks for that (as is already the case for MK_TESTS and > src.opts.mk). On head, it should work without local hacks. I allow you to change the shell via TEST_SH -- is that acceptable for the first drop (I'll look at revising the code to permit runtime overrides via kyua)? > 2. Allow installing using a read-only /usr/obj (mounted over NFS). This > means that everything needs to be built during buildworld. > Installworld should not build anything. > (I currently have local hacks: Kyuafile.auto is not built so I added > all: Kyuafile.auto > to some tests/Makefiles; I guess this should be in <bsd.test.mk>.) That's another issue entirely that you brought up in another thread. I'll see if that's still an issue.. Thank you! -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMAOK7ccth%2B3VbpCputnxsMTnp-8JtUmw=QovRhehK=toA>