Date: Sun, 14 Sep 2014 12:10:06 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Bruce Evans <brde@optusnet.com.au> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, Garrett Cooper <ngie@freebsd.org>, "svn-src-user@freebsd.org" <svn-src-user@freebsd.org> Subject: Re: svn commit: r271574 - user/ngie/add-pjdfstest/contrib/pjdfstest Message-ID: <916E2311-C6BF-423E-A149-3F1853584020@gmail.com> In-Reply-To: <20140914200428.P1559@besplex.bde.org> References: <201409140909.s8E99ncV087445@svn.freebsd.org> <20140914200428.P1559@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Sep 14, 2014, at 4:21, Bruce Evans <brde@optusnet.com.au> wrote:
>=20
>> On Sun, 14 Sep 2014, Garrett Cooper wrote:
>>=20
>> Log:
>> Redo r271374 by using the right typecast for comparing i and ngroups
>=20
> It is still quite broken (more broken than without the cast, since the
> cast breaks the warning).
Hi Bruce,
I completely agree with your concerns. Since this is "contrib" code I wa=
nted to make the smallest set of changes to make things compile, then push f=
or the proper fix upstream.
As an aside, is u_int completely portable; I personally prefer the longe=
r forms of non-fixed width types, e.g. unsigned int, but that's my personal p=
reference.
Thank you!
-Garrett=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?916E2311-C6BF-423E-A149-3F1853584020>