Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 2 Jun 2023 15:30:55 +0000
From:      Gary Jennejohn <garyj@gmx.de>
To:        current@freebsd.org
Subject:   Re: Error building kernel in current
Message-ID:  <20230602173055.583db61d@ernst.home>
In-Reply-To: <20230602115940.7c9d2f4e@ernst.home>
References:  <20230602115644.7ce88b9f@ernst.home> <20230602115940.7c9d2f4e@ernst.home>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2 Jun 2023 09:59:40 +0000
Gary Jennejohn <garyj@gmx.de> wrote:

> On Fri, 2 Jun 2023 09:56:44 +0000
> Gary Jennejohn <garyj@gmx.de> wrote:
>
> > Error building kernel in current:
> >
> > --------------------------------------------------------------
> > >>> stage 3.1: building everything
> > --------------------------------------------------------------
> > /usr/src/sys/netlink/route/iface.c:1315:22: error: use of undeclared
> > identifier 'if_flags'
> >         if (error =3D=3D 0 && !(if_flags & IFF_UP) && (if_getflags(ifp=
) & IFF_UP))
> >                             ^
> > 1 error generated.
> > --- iface.o ---
> > *** [iface.o] Error code 1
> >
> > My source tree was updated just a few minutes ago and I didn't see any
> > recent changes to iface.c.
> >
> > I have WITHOUT_NETLINK_SUPPORT=3D in my src.conf.
> >
>
> Ah, my error.  The failure occurs while building the kernel, so I fixed
> Subject accordingly.
>

OK, this is another INET6 error.  I don't have INET6 enabled.

At line 1280 we have:
#ifdef INET6
	int if_flags =3D if_getflags(ifp);
#endif

and if_flags is used at line 1315 without checking whether INET6 is
defined.

if_flags seems to be totally redundant, since the code at line 1315 will
invoke if_getflags(ifp) if !(if_flags & IFF_UP) is true.

=2D-
Gary Jennejohn



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230602173055.583db61d>