Date: Thu, 6 Jul 2000 17:01:19 -0700 (PDT) From: Archie Cobbs <archie@whistle.com> To: julian@elischer.org (Julian Elischer) Cc: dberlin@cygnus.com (Daniel Berlin), brian@Awfulhak.org (Brian Somers), archie@whistle.com (Archie Cobbs), dan@cgsoftware.com (Daniel Berlin), freebsd-current@FreeBSD.ORG Subject: Re: PPPoE not working Message-ID: <200007070001.RAA14545@bubba.whistle.com> In-Reply-To: <3964A7A8.41C67EA6@elischer.org> from Julian Elischer at "Jul 6, 2000 08:37:12 am"
next in thread | previous in thread | raw e-mail | index | archive | help
Julian Elischer writes: > > > The code's in ppp/ether.c. > > > > > > I'll see if I can get time to figure out what's wrong, but I can't > > > promise anything this week. I'm too busy (we're having a FreeBSD > > > mini-conference here in the UK at which I'm speaking...). > > > > > I already solved this one, the problem is that the source address is being overwritten with 0's. > > As a temporary hack, if you go into ng_pppoe.c, and replace the 0's with your ethernet address, you'll be golden. > > Actually Archie left out code to add IN the source MAC address. > so it wasn;t being overwritten, it was never being set.... > > I just committed a fix. > let me know the result Julian, Thanks for the fix. However, this seems like the wrong fix to me. I think the right fix would be for ppp(8) to set the source address, rather than always forcing it in ng_ether.c... that way the "lower" hook really is WYSIWYG and applications where other source addresses may want to be used are possible. I thought the semantics of writing to "lower" or "orphans" were to be that the packet gets delivered out the link exactly "as-is", unchanged. Having the correct source address should be optional. Perhaps there could be a control message to set an "add source address" bit. While we're at it, we could also use a control message to get the unique Ethernet address, turn promiscuous mode on/off, and add multicast addresses. What do you guys think? -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200007070001.RAA14545>