Date: Mon, 25 Nov 2002 03:19:13 +0200 From: Giorgos Keramidas <keramida@ceid.upatras.gr> To: Terry Lambert <tlambert2@mindspring.com> Cc: freebsd-chat@FreeBSD.ORG Subject: Re: Style(9) question Message-ID: <20021125011913.GH15728@gothmog.gr> In-Reply-To: <3DE178ED.6883CEC2@mindspring.com> References: <20021122193040.GA23078@dogma.freebsd-uk.eu.org> <20021122214405.GA11011@HAL9000.homeunix.com> <8gof8g83w4.f8g@localhost.localdomain> <20021124090603.GA3172@HAL9000.homeunix.com> <20021124100846.GC51850@raggedclown.net> <20021124162717.GA576@gothmog.gr> <3DE1739B.5AD2AEA7@mindspring.com> <20021125010242.GE15728@gothmog.gr> <3DE178ED.6883CEC2@mindspring.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2002-11-24 17:12, Terry Lambert <tlambert2@mindspring.com> wrote: > Giorgos Keramidas wrote: > > I am more in favor of fixing any style issues, then commiting the > > fix, and closing the PR with a notice to the spirit of "I have > > changed the diff a bitt, because of `foo', and have committed it > > in revision x.y.z of `bar'." > > This is good too. It puts the style(9) compliance onus onto > people who care. :) > The issue, though, was rejection of bug fixes on the basis of > style(9). Which is hopefully answered above. We can have both. The committer who makes the changes is free to make changes to the diff, and bring it closer to style(9) either a) before committing the changes, or b) afterwards. The fact that there is an existing style is orthogonal to fixing of bugs. One can both fix bug and keep the existing style, or do either of the two, without necessarily depending on the other. > The heart of the issue is which of the two things is more > important: compliance with style(9), or the fixing of bugs. Both. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-chat" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021125011913.GH15728>