Date: Sat, 31 Jan 2004 12:53:55 -0800 From: John-Mark Gurney <gurney_j@efn.org> To: "Greg J." <xcas@cox.net> Cc: freebsd-amd64@freebsd.org Subject: Re: msdosfs patch Message-ID: <20040131205355.GY74366@funkthat.com> In-Reply-To: <401C02A9.5030506@cox.net> References: <200401311932.37140.adridg@cs.kun.nl> <401C02A9.5030506@cox.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Greg J. wrote this message on Sat, Jan 31, 2004 at 12:31 -0700:
> >Since Tim didn't mail his patch to the amd64 list, perhaps you could
> >re-post it there?
> oops.. I thought Tim's patch went to the freebsd-amd64 list as well..
> sorry. It's attached to this email. :)
looks good, though was this (mis)spelling of size_t intentional?
[...]
> static u_int16_t unix2doschr(const u_char **, size_t *, struct msdosfsmount *);
[...]
> - int i, j, l;
> + ssize_t i, j;
> + int l;
> int conv = 1;
> const u_char *cp, *dp, *dp1;
> u_char gentext[6], *wcp;
> @@ -531,7 +532,7 @@
> * Filenames with some characters are not allowed!
> */
> for (cp = un, i = unlen; i > 0;)
> - if (unix2doschr(&cp, (size_t *)&i, pmp) == 0)
> + if (unix2doschr(&cp, &i, pmp) == 0)
> return 0;
>
> /*
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040131205355.GY74366>