Date: Wed, 2 Jun 2004 06:56:25 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Oliver Eikemeier <eikemeier@fillmore-labs.com> Cc: Kris Kennaway <kris@obsecurity.org> Subject: Re: INDEX patch Message-ID: <20040602135625.GA56115@xor.obsecurity.org> In-Reply-To: <40BDDB39.9090106@fillmore-labs.com> References: <20040602121648.GA51625@xor.obsecurity.org> <40BDCC4B.9000708@fillmore-labs.com> <20040602132149.GA55452@xor.obsecurity.org> <40BDD8B6.80103@fillmore-labs.com> <20040602134340.GA55881@xor.obsecurity.org> <40BDDB39.9090106@fillmore-labs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--XsQoSWH+UP9D9v3l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 02, 2004 at 03:50:49PM +0200, Oliver Eikemeier wrote: > >>Because test is a sh-builtin, and the file system should cache this=20 > >>information > >>I don't expect to see any difference. Especially since spawning perl=20 > >>11000 times > >>is more than suboptimal ;) You didn't mean this serious, did you? > > > >I did, because I care about small pessimizations of the INDEX build. > >Sometimes they're not small. Did you benchmark it? >=20 > No. Did you?=20 I did, actually. Removing the ECHO_CMD is a small but measurable improvement (and not negligible when the total index build time is only 120 seconds, which I've achieved with other optimizations). This is a silly argument though, because you just need to test for the existence of perl once in /usr/ports/Makefile. > Honestly, when you really want to improve INDEX building=20 > times, it > should be worth thinking about not spawning perl every time, but instead = do=20 > the > substitutions in batch. I my experience microoptimization on the expense = of > clarity and prudence almost always result in highly optimized suboptimal > algorithms that together run far slower that they have to. This sounds like a good idea for future improvement. Can you take a look at implementing it? Kris --XsQoSWH+UP9D9v3l Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAvdyJWry0BWjoQKURAm2tAKC/WvBgr9AsQPAWsfir851INHBlvwCfRNsF +W1ISzcwZe34Pq5lUFkfdkI= =c6AL -----END PGP SIGNATURE----- --XsQoSWH+UP9D9v3l--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040602135625.GA56115>