Date: Thu, 2 Mar 2006 10:35:51 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Maksim Yevmenkin <maksim.yevmenkin@savvis.net> Cc: freebsd-current@freebsd.org Subject: Re: [PATCH] kbdmux(4) and devd(8) Message-ID: <20060302183551.GD12226@odin.ac.hmc.edu> In-Reply-To: <44073955.6050202@savvis.net> References: <44062DE7.8090508@savvis.net> <20060302180612.GB12226@odin.ac.hmc.edu> <44073955.6050202@savvis.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 02, 2006 at 10:28:37AM -0800, Maksim Yevmenkin wrote:
> Brooks Davis wrote:
> >On Wed, Mar 01, 2006 at 03:27:35PM -0800, Maksim Yevmenkin wrote:
> >
> >>Dear Hackers,
> >>
> >>any comments/objections/etc. to the following devd.conf patch? the idea
> >>is to prevent devd(8) from trying to switch keyboards when kbdmux(4) is
> >>the default keyboard.
> >>
> >>the 'attach' action will fail anyway, however, the 'detach' action may
> >>succeed (if /dev/kbd0 is not is the kbdmux(4)).
> >
> >
> >This seems OK if a bit ugly to me. Another idea might be to add some
> >new methods to /etc/rc.d/syscons (or create a new keyboard management
> >script) to hide the logic there.
>
> do you mean something like
Yes, that's what I was thinking.
-- Brooks
> --- syscons.orig Thu Jan 5 15:36:02 2006
> +++ syscons Thu Mar 2 10:25:49 2006
> @@ -34,8 +34,10 @@
> . /etc/rc.subr
>
> name="syscons"
> +extra_commands="setkeyboard"
> start_precmd="syscons_precmd"
> start_cmd="syscons_start"
> +setkeyboard_cmd="syscons_setkeyboard"
>
> # stdin must be redirected because it might be for a serial console
> #
> @@ -206,5 +208,19 @@
> echo '.'
> }
>
> +syscons_setkeyboard()
> +{
> + kbd=$1
> +
> + if [ -z "${kbd}" ]; then
> + return 1
> + fi
> +
> + kbdcontrol -i < ${kbddev} | grep kbdmux > /dev/null 2>&1
> + if [ $? != 0 ]; then
> + kbdcontrol -k /dev/${kbd} < ${kbddev} > /dev/null 2>&1
> + fi
> +}
> +
> load_rc_config $name
> -run_rc_command "$1"
> +run_rc_command $*
>
>
> thanks,
> max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060302183551.GD12226>