Date: Fri, 28 Apr 2006 17:47:26 -0600 From: Scott Long <scottl@samsco.org> To: Mike Jakubik <mikej@rogers.com> Cc: protagonist@gmx.net, freebsd-amd64@freebsd.org Subject: Re: nve(4) timeout fix Message-ID: <4452A98E.8020501@samsco.org> In-Reply-To: <44528643.4050103@rogers.com> References: <20060427120035.D7FA016A43B@hub.freebsd.org> <4450D0E8.4000403@uchicago.edu> <vita-brevis-breviter-in-brevi-finietur-mors-venit-velociter-quae-neminem-veretur-868xppk0tz.fsf@shodan.gothgoose.net> <200604281646.46451.jhb@freebsd.org> <44528643.4050103@rogers.com>
index | next in thread | previous in thread | raw e-mail
Mike Jakubik wrote: > John Baldwin wrote: > >> On Friday 28 April 2006 14:32, Marcus Frings wrote: >> >> >>> * Nathan Whitehorn <nathanw@uchicago.edu> wrote: >>> >>> >>> >>>> Also on the subject of nVidia NICs, I've fixed the device timeout >>>> problem on nve(4). It appears that some revisions of the hardware don't >>>> send interrupts on tx completion, which caused watchdog timeouts under >>>> low load. We should take this hardware quirk into account for the nfe >>>> port as well. >>>> >>> >>> I also applied this patch to my FreeBSD 6.1RC (Asus A8N-E) for testing >>> and it works perfectly. By now I don't have any timeouts anymore! >>> >>> Will it be added to the official release of 6.1 or CURRENT? >>> >> >> >> It's in current but is probably too late for 6.1. >> >> > > > Why is it too late? If it fixes a known stability problem, then why cant > it be commited? If no commits are allowed during the -RC phase, then > what is 6.1-RELEASE waiting for? > Because there is always a last minute stream of bug fixes, and when you wait for one, another one comes up that you wait for, then another, etc, etc. At some point we have to draw the line. Also, it's good to let changes shake out for a few days before cutting a release. It's not uncommon for serious problems to be exposed several days after a commit. SO again, we have to draw the line somewhere. Scotthome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4452A98E.8020501>