Date: Tue, 21 May 2019 09:48:05 -0700 (PDT) From: "Rodney W. Grimes" <freebsd-rwg@gndrsh.dnsmgr.net> To: John Baldwin <jhb@FreeBSD.org> Cc: "Rodney W. Grimes" <freebsd-rwg@gndrsh.dnsmgr.net>, Robert Crowston <crowston@protonmail.com>, freebsd-virtualization@FreeBSD.org Subject: Re: Windows 10 guests fail to boot when attempting to passthrough network card Message-ID: <201905211648.x4LGm5eW079975@gndrsh.dnsmgr.net> In-Reply-To: <4460bfe3-ccc8-f982-9097-954c01331502@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 5/19/19 6:24 AM, Rodney W. Grimes wrote: > >> Does the card have multiple BARs? Can you send us the output of pciconf -lvb for the card? > >> > >> There is a bug in bhyve where if the OS assigns the 0xffffffff sentinel to more than one BAR simultaneously it is not compatible with bhyve?s memory model for the guest. > > > > The "we talked" below is myself and Nick talking about exactly that > > which came from jhb@ pointing out to me in a hall wall > > conversation here at BSDCan that this is the cause of this > > problem and is a known issue. > > > > Does anyone have fixes for this issue? > > I have not tested this at all, but I have a candidate patch to fix the root > issue at https://github.com/freebsd/freebsd/compare/master...bsdjhb:bhyve_passthrough_barsize Could you please factor out the white space changes and do that seperately and sooner, it clouds the S/N in this review a bit. > My first guess at the problem wasn't quite right (though Windows does indeed size > BARs in parallel). For pass-through devices we aren't currently correctly disabling > access to a BAR when the guest disables it in the PCI command register which in > turn trips the assertion when using a Windows guest, but in general we need to be > honoring the enable bits when set or cleared by the guest. That makes more since to me. Thanks. > -- > John Baldwin -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201905211648.x4LGm5eW079975>