Date: Mon, 14 May 2007 09:39:13 -0500 From: Stephen Montgomery-Smith <stephen@math.missouri.edu> To: "[LoN]Kamikaze" <LoN_Kamikaze@gmx.de> Cc: Pav Lucistnik <pav@freebsd.org>, freebsd-ports@freebsd.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: Time to abandon recursive pulling of dependencies? Message-ID: <46487491.6020806@math.missouri.edu> In-Reply-To: <4647F182.6000402@gmx.de> References: <464597C6.3030406@gmx.de> <20070512174011.GA22526@xor.obsecurity.org> <4645FF71.60100@gmx.de> <20070512175824.GA23103@xor.obsecurity.org> <20070512133054.B5588@math.missouri.edu> <4646193E.5040503@gmx.de> <464665D5.1090509@math.missouri.edu> <464676CC.2000203@math.missouri.edu> <46469BF5.9030603@math.missouri.edu> <1179058696.13237.3.camel@ikaros.oook.cz> <20070513101332.L82202@math.missouri.edu> <46479215.1080401@math.missouri.edu> <4647C4FB.9050607@math.missouri.edu> <4647F182.6000402@gmx.de>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------080504010008050606060700 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit [LoN]Kamikaze wrote: > Stephen Montgomery-Smith wrote: >> Basically I think we are stuck on making "make package-depends" go any >> faster. >> >> However I do think that the modifications I made to pkg_create go a very >> significant way to solving the problem of registration taking so very long. >> >> Stephen >> > > You are right about invoking make being the problem. However, I was able to > increase the performance of package-depends by 20 to 30 percent, by avoiding > recursive make calls and moving the recursion into the stack of the shell > invocation. > > With my changes there's less than 10% overhead over the sum of make calls. I.e. > for 56 seconds of make calls (x11/xorg on my system) there are only 4 more > seconds of processing, instead of 15 to 20 seconds. > > The original make package-depends does some things I don't understand. Once > I've figured them out I will post my little patch here. > > Someone pointed out that what I was proposing in +DEPENDENCIES is already to be found in +CONTENTS. So here is a proof of concept patch to /usr/ports/Mk/bsd.port.mk (proof of concept because no error checking, and things like that). For me it makes registration about 3 times faster. --------------080504010008050606060700 Content-Type: text/plain; name="ddd" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="ddd" LS0tIGJzZC5wb3J0Lm1rLW9yaWcJTW9uIE1heSAxNCAwOToyODo0MiAyMDA3CisrKyBic2Qu cG9ydC5tawlNb24gTWF5IDE0IDA5OjMzOjM5IDIwMDcKQEAgLTIzODcsNyArMjM4Nyw3IEBA CiBESVNBQkxFX0NPTkZMSUNUUz0JWUVTCiAuZW5kaWYKIC5pZiAhZGVmaW5lZChQS0dfQVJH UykKLVBLR19BUkdTPQkJLXYgLWMgLSR7Q09NTUVOVDpRfSAtZCAke0RFU0NSfSAtZiAke1RN UFBMSVNUfSAtcCAke1BSRUZJWH0gLVAgImBjZCAkey5DVVJESVJ9ICYmICR7TUFLRX0gcGFj a2FnZS1kZXBlbmRzIHwgJHtHUkVQfSAtdiAtRSAke1BLR19JR05PUkVfREVQRU5EU30gfCAk e1NPUlR9IC11YCIgJHtFWFRSQV9QS0dfQVJHU30gJCR7X0xBVEVfUEtHX0FSR1N9CitQS0df QVJHUz0JCS12IC1jIC0ke0NPTU1FTlQ6UX0gLWQgJHtERVNDUn0gLWYgJHtUTVBQTElTVH0g LXAgJHtQUkVGSVh9IC1QICJgY2QgJHsuQ1VSRElSfSAmJiAke01BS0V9IGFjdHVhbC1wYWNr YWdlLWRlcGVuZHMgfCAke0dSRVB9IC12IC1FICR7UEtHX0lHTk9SRV9ERVBFTkRTfSB8ICR7 U09SVH0gLXVgIiAke0VYVFJBX1BLR19BUkdTfSAkJHtfTEFURV9QS0dfQVJHU30KIC5pZiAh ZGVmaW5lZChOT19NVFJFRSkKIFBLR19BUkdTKz0JCS1tICR7TVRSRUVfRklMRX0KIC5lbmRp ZgpAQCAtNTIxNiwxMCArNTIxNiwyNiBAQAogCQlmaTsgXAogCWRvbmUKIAorQUNUVUFMLVBB Q0tBR0UtREVQRU5EUz89IFwKKwlwa2dzPWAoZm9yIGRpciBpbiAke19MSUJfUlVOX0RFUEVO RFM6QyxbXjpdKjooW146XSopOj8uKixcMSx9OyBkbyBcCisJCWRpcj0kJCgke1JFQUxQQVRI fSAkJGRpcik7IFwKKwkJaWYgWyAtZCAkJGRpciBdOyB0aGVuIFwKKwkJCXBrZ25hbWU9JCQo Y2QgJCRkaXI7ICR7TUFLRX0gLVYgUEtHTkFNRSk7IFwKKwkJCSR7RUNIT19DTUR9ICQkcGtn bmFtZTsgXAorCQkJJHtHUkVQfSBAcGtnZGVwIC92YXIvZGIvcGtnLyQkcGtnbmFtZS8rQ09O VEVOVFMgfCAke1NFRH0gInMvQHBrZ2RlcCAvLyI7IFwKKwkJZmk7IFwKKwlkb25lKSB8IHNv cnQgLXVgOyBcCisJZm9yIHBrZ25hbWUgaW4gJCRwa2dzOyBkbyBcCisJCSR7RUNIT19DTUR9 ICQkcGtnbmFtZWAke0dSRVB9ICJAY29tbWVudCBPUklHSU46IiAvdmFyL2RiL3BrZy8kJHBr Z25hbWUvK0NPTlRFTlRTIHwgJHtTRUR9ICJzL0Bjb21tZW50IE9SSUdJTi8vImA7IFwKKwlk b25lCisKICMgUHJpbnQgb3V0IHBhY2thZ2UgbmFtZXMuCiAKIHBhY2thZ2UtZGVwZW5kczoK IAlAJHtQQUNLQUdFLURFUEVORFMtTElTVH0gfCAke0FXS30gJ3twcmludCAkJDEiOiIkJDN9 JworCithY3R1YWwtcGFja2FnZS1kZXBlbmRzOgorCUAke0FDVFVBTC1QQUNLQUdFLURFUEVO RFN9CiAKICMgQnVpbGQgcGFja2FnZXMgZm9yIHBvcnQgYW5kIGRlcGVuZGVuY2llcwogCg== --------------080504010008050606060700--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46487491.6020806>