Date: Mon, 08 Sep 2008 23:43:52 +0200 From: Pietro Cerutti <gahr@FreeBSD.org> To: Nate Lawson <nate@root.org> Cc: freebsd-acpi@FreeBSD.org, bug-followup@FreeBSD.org Subject: Re: kern/124223: [acpi] [patch] acpi_battery.c -- Notify user-defined critical level via devd(8) Message-ID: <48C59C98.5020408@FreeBSD.org> In-Reply-To: <48C16810.2030003@root.org> References: <48C14091.4060309@FreeBSD.org> <48C16810.2030003@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Nate Lawson wrote:
| There are a few problems with your approach.
|
| Critical status is already reported with a flag when usermode polls for
| the battery status:
|> if (sc->bst.state & ACPI_BATT_STAT_CRITICAL) {
|> if ((sc->flags & ACPI_BATT_STAT_CRITICAL) == 0) {
|> sc->flags |= ACPI_BATT_STAT_CRITICAL;
|> device_printf(dev, "critically low charge!\n");
|> }
|> }
I agree. Critical level is already checked for in the cmbat module.
However, reporting is not done in a "standardized" way. My patch would
just like to add notification through devd.
| Since usermode utilities already poll, they can handle that flag or
| implement their own notion of critical battery level. Why introduce a
| new kernel thread to do that same polling?
Because you can't configure the notion of "critical level" via cmbat.
|
| Don't common battery status tools that poll (say, xbatt) have their own
| way to set a critical level?
xbatt uses APM and ioctl to get the status of the battery.
I agree that userlevel utilities can e.g., retrieve the remaining
percent and set the critical level arbitrarily, but I anyway think that
a configurable level to be seen as critical by the OS could be a useful
addition.
I'm open to discussions about the best way to implement it (cmbat,
battery, ...?), if we get to an agreement that this could be a useful
feature :) Otherwise feel free to close the PR, as I can accept your
arguments.
|
| -Nate
|
| Pietro Cerutti wrote:
|> POKE!
|>
|> Anybody interested in reviewing it?
|
- --
Pietro Cerutti
gahr@FreeBSD.org
PGP Public Key:
http://gahr.ch/pgp
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)
iEYEAREKAAYFAkjFnJcACgkQwMJqmJVx946mtgCgivQVqG6nrctsffXFdm5HRQfX
1OUAoL9TXYwwiNfHvnUclKAhVzWcnw9S
=3q5J
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48C59C98.5020408>