Date: Thu, 12 Nov 2009 02:46:14 +0100 From: Attilio Rao <attilio@freebsd.org> To: "Justin T. Gibbs" <gibbs@scsiguy.com> Cc: gibbs@freebsd.org, freebsd-current@freebsd.org, Scott Long <scottl@freebsd.org>, Ed Maste <emaste@sandvine.com> Subject: Re: [PATCH] Adding sysctl for errors statistics to ahd(4) Message-ID: <3bbf2fe10911111746g48c8fb82r74744dffedf49758@mail.gmail.com> In-Reply-To: <4AFAEE89.3020009@scsiguy.com> References: <3bbf2fe10911060643g60079e31y7679b32dac670fd8@mail.gmail.com> <4AFAEE89.3020009@scsiguy.com>
next in thread | previous in thread | raw e-mail | index | archive | help
2009/11/11 Justin T. Gibbs <gibbs@scsiguy.com>: > On 11/6/2009 7:43 AM, Attilio Rao wrote: >> This patch introduces some mechanisms for collecting informations on >> errors frequency and debugging (and relative sysctls for printing them >> out) for the ahd(4) driver: >> http://www.freebsd.org/~attilio/Sandvine/STABLE_8/ahd/ahd-current2.diff >> >> The usage of array for sysctls is a bit too paranoid but it allows for >> further extendibility of the code and doesn't loose of cleaness. >> This code has been contributed back by Sandvine Incorporated with some >> cleanups. >> Please review. >> >> Thanks, >> Attilio > > In general, I think the patch is fine. It violates the existing style > of the driver in some places (e.g. the aic7xxx drivers wrap function > arguments to the opening '(' not to a 4 space indent), which should > probably be addressed so the code remains consistent. Sorry, I cannot find where these existing style breakage happens, could you be a bit more precise? (I just found an un-sorted header introduction in aic79xx.h that I will fix). Anyways, your idea about a generalized interface in newbus for handling that is not bad and as long as I'm planning some works in this area I can add this item to the TODO list. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3bbf2fe10911111746g48c8fb82r74744dffedf49758>