Date: Mon, 24 Oct 2011 07:59:54 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-current@freebsd.org Cc: Garrett Cooper <yanegomi@gmail.com>, Craig Rodrigues <rodrigc@crodrigues.org>, Doug Barton <dougb@freebsd.org>, "Luchesar V. ILIEV" <luchesar.iliev@gmail.com> Subject: Re: sys/conf/newvers.sh vs. subversion-1.7 Message-ID: <201110240759.54727.jhb@freebsd.org> In-Reply-To: <4EA2EFDD.4020507@gmail.com> References: <20111020114844.GK59810@albert.catwhisker.org> <alpine.BSF.2.00.1110220801140.38610@toaster.local> <4EA2EFDD.4020507@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, October 22, 2011 12:31:25 pm Luchesar V. ILIEV wrote:
> Speaking of that, and in the context of the recursion that svnversion
> does, something else comes to my mind...
>
> svnversion is currently executed in ${SRCDIR}/sys, so the revision
> number is relevant only to the kernel sources. But FreeBSD is not just a
> kernel, unlike Linux, so wouldn't it make more sense to actually check
> the revision directly at ${SRCDIR}, thus catching possible different
> revisions in other parts of the base system source tree?
Please no. That makes svnversion take a _lot_ longer. We used to do that,
but changed it. Also, the kernel build does not use any sources outside
of sys/, so for the kernel an svnversion of sys/ is perfectly reasonable.
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201110240759.54727.jhb>