Date: Mon, 16 Jul 2012 13:40:14 -0700 From: Jack Vogel <jfvogel@gmail.com> To: Andre Oppermann <oppermann@networx.ch> Cc: freebsd-net@freebsd.org, Ihsan Junaidi Ibrahim <ihsan@grep.my> Subject: Re: Enable LRO by default on igb Message-ID: <CAFOYbc=qgjnVVC757WkV5CYUvOy3Es=%2BJEe9KtYEtGWqCgZxFA@mail.gmail.com> In-Reply-To: <50047207.8060004@networx.ch> References: <3AC8C112-A80B-4D8F-89DA-DA38E4AB524F@grep.my> <CAFOYbcn6ETrNFGLBS1r46Jovr7p5QbdcuCKyheA_xw18GiYgtw@mail.gmail.com> <0FF9D20C-4D88-484F-AEB9-E6F10094E018@grep.my> <50047207.8060004@networx.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
Right, I was aware of the fix, so is there enough interest in this to have me get it enabled in the driver before 9.1 releases, its a couple lines of change and I'm fine with making it ?? Jack On Mon, Jul 16, 2012 at 12:56 PM, Andre Oppermann <oppermann@networx.ch>wrote: > On 13.07.2012 02:21, Ihsan Junaidi Ibrahim wrote: > >> I did a quick file download test on the LRO-enabled device (forwarding is >> turned on) and there's >> no perceive drop-off in forwarding performance. >> > > LRO must not be active on any interface when forwarding is enabled. > This has been fixed by bz@ in current and stable/9 within the LRO > code and is automatic. > > The only remaining unhandled case is hardware-LRO where the driver > must tell the hardware to stop doing it. Eventually we need an > eventhandler for that and hardware-LRO cards have to register with > it to get informed on changes there. > > -- > Andre > > > The test is very unscientific (over the Internet) as I don't have access >> to a local test bed >> where I can do more in-depth testing. >> >> Sysctl LRO stats gave me these: dev.igb.0.queue0.lro_queued: 53 >> dev.igb.0.queue0.lro_flushed: 53 >> dev.igb.0.queue1.lro_queued: 121 dev.igb.0.queue1.lro_flushed: 120 >> dev.igb.0.queue2.lro_queued: >> 14895 dev.igb.0.queue2.lro_flushed: 8200 dev.igb.0.queue3.lro_queued: 77 >> dev.igb.0.queue3.lro_flushed: 76 >> >> Just curious on why flushed and queued numbers did not seem to match. >> >> ihsan >> >> On Jul 8, 2012, at 12:26 AM, Jack Vogel wrote: >> >> Because of problems with forwarding when it was turned on, however this >>> has recently been fixed >>> supposedly, if someone using the driver in an environment with >>> forwarding could verify that >>> there is no problem with it enabled I'd be happy to change it to be on >>> by default. >>> >>> Jack >>> >>> >>> On Sat, Jul 7, 2012 at 9:01 AM, Ihsan Junaidi Ibrahim <ihsan@grep.my> >>> wrote: >>> >>> Hi folks, >>>> >>>> Just curious is there a reason why LRO isn't turned on by default for >>>> igb(4) like for other >>>> capabilities? >>>> >>>> I have a couple of 82575EB igb devices and LRO had to be turned on >>>> manually. >>>> >>>> Thanks._______________________**________________________ >>>> freebsd-net@freebsd.org mailing list >>>> http://lists.freebsd.org/**mailman/listinfo/freebsd-net<http://lists.freebsd.org/mailman/listinfo/freebsd-net>To unsubscribe, send any mail to >>>> "freebsd-net-unsubscribe@**freebsd.org<freebsd-net-unsubscribe@freebsd.org> >>>> " >>>> >>>> ______________________________**_________________ >>> freebsd-net@freebsd.org mailing list >>> http://lists.freebsd.org/**mailman/listinfo/freebsd-net<http://lists.freebsd.org/mailman/listinfo/freebsd-net>To unsubscribe, send any mail to >>> "freebsd-net-unsubscribe@**freebsd.org<freebsd-net-unsubscribe@freebsd.org> >>> " >>> >> >> ______________________________**_________________ freebsd-net@freebsd.orgmailing list >> http://lists.freebsd.org/**mailman/listinfo/freebsd-net<http://lists.freebsd.org/mailman/listinfo/freebsd-net>To unsubscribe, send any mail to >> "freebsd-net-unsubscribe@**freebsd.org<freebsd-net-unsubscribe@freebsd.org> >> " >> >> >> > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFOYbc=qgjnVVC757WkV5CYUvOy3Es=%2BJEe9KtYEtGWqCgZxFA>