Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 6 Sep 2012 18:10:36 -0400
From:      Glen Barber <gjb@FreeBSD.org>
To:        Doug Barton <dougb@FreeBSD.org>
Cc:        rc@FreeBSD.org
Subject:   Re: [PATCH] Allow use of program path overrides
Message-ID:  <20120906221036.GF1332@glenbarber.us>
In-Reply-To: <50491DB2.1020702@FreeBSD.org>
References:  <20120906195706.GD1332@glenbarber.us> <50491DB2.1020702@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
On Thu, Sep 06, 2012 at 03:03:30PM -0700, Doug Barton wrote:
> On 9/6/2012 12:57 PM, Glen Barber wrote:
> > Hi,
> > 
> > Many rc(8) scripts have corresponding 'foo_program="/path/to/foo"' 
> > entries in etc/defaults/rc.conf .
> 
> These are usually only added for things that might get overridden by
> something from ports.
> 

I can think of valid reasons one might want to do this otherwise.

> > However, some are missing the functionality to override $command 
> > correctly.
> 
> rc.subr should already do that. Have you tested it?
> 

Yes.  See the previous thread on -rc@ .

> > The attached patch:
> > 
> > - Adds missing "${name}_program=/path/to/${name}" entries to 
> > defaults/rc.conf
> 
> Please don't do that. :)
> 
> > - Adds missing functionality of setting 
> > "command=${foo_program:-/path/to/foo}" in corresponding rc(8) 
> > scripts.
> 
> Please don't do this either. :)
> 

Ok.  I'll bite.  "Why not?"

Glen


[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iQEcBAEBCAAGBQJQSR9cAAoJEFJPDDeguUajYnYH/1hXxZgSwmzH1+gVAjtAxtuA
+3gtnfJqH5hCiLo254nBk5fNqBh0qrnZDxLPbKyp4y8yD701G/MHZ6DD7yYCUHJ2
P5o6cGEyk3S97nDCUa+e/QXvlUh4WPsDXUVK6EreKwdghSHDn4xQRwU97YbLFxql
H4ejWeTK4S8/ytadP6U5H+mm3yknAgWoYqFXEMkomOrGgwKU1AKOGzLjT0oZThis
HCNdzejB+EQuPVpQSLuZOtBQAAgFMTll2m/bFBgsFauVjYNxNN7v+H++kidIic8u
lJE+ZnKHkswQOSkzzuf1p48g5mX5zhp5Sn/S+/2YEYOrDPaDubGznGRzOZDmA7o=
=smB5
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120906221036.GF1332>