Date: Sat, 8 Dec 2012 17:04:13 -0500 From: Eitan Adler <lists@eitanadler.com> To: Guido Falsi <madpilot@freebsd.org> Cc: freebsd-doc@freebsd.org, bapt@freebsd.org Subject: Re: Patch for porter's handbook Message-ID: <CAF6rxg=V9RHeeY=e39xaJDzKFw6a_k%2BbqVR7k%2B942O5q1PfhYw@mail.gmail.com> In-Reply-To: <50C3B788.6050809@FreeBSD.org> References: <50C3AEE6.3020101@FreeBSD.org> <CAF6rxgkDTMgsNuu8%2BtpahmAXeHHVftxPQ6AeSR2pcrr3_YNawg@mail.gmail.com> <50C3B788.6050809@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8 December 2012 16:56, Guido Falsi <madpilot@freebsd.org> wrote: > On 12/08/12 22:22, Eitan Adler wrote: >> >> On 8 December 2012 16:19, Guido Falsi <madpilot@freebsd.org> wrote: >>> >>> Hi! >>> Some time ago the maintainer of net-mgmt/mrtg noticed that the porter's >>> handbook still reference NOPORTDOCS in place of the new DOCS option in >>> optionsng. >>> >>> I have a patch(attached) which fixes this. bapt has already seen it and >>> approved it, as suggested by him I added a tag around "DOCS". >>> >>> I'd like this patch to be revised by someone of the documentation team >>> and >>> approved for committing it. I'm obviously accepting any comment or >>> correction. >> >> >> The content changes look good. However, please don't make whitespace / >> formatting changes in the same patch as this makes it harder to figure >> out what changed for both the reviewers and translators. >> >> > > Good point. Here is a revised patch with only the content changes included. Looks good to me. Not your text but: "and neither would be added to port packing list" doesn't sound quite right. Try replacing "and neither would be" with "or". -- Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=V9RHeeY=e39xaJDzKFw6a_k%2BbqVR7k%2B942O5q1PfhYw>