Date: Fri, 15 May 2015 14:15:18 +0200 From: Julien Charbon <jch@freebsd.org> To: freebsd-net@freebsd.org Cc: John Baldwin <jhb@freebsd.org>, Jason Wolfe <nitroboost@gmail.com>, hiren panchasara <hiren@freebsd.org>, Sean Chittenden <sean@chittenden.org> Subject: Re: MFC-ing TCP timer race condition fix Message-ID: <5555E356.8080000@freebsd.org> In-Reply-To: <5548EC8F.3010103@freebsd.org> References: <5548BB20.2020700@freebsd.org> <5548EC8F.3010103@freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Hi, On 05/05/15 18:15, Julien Charbon wrote: > I was asked if it is possible to MFC r281599 in FreeBSD 10: > > --- > Fix an old and well-documented use-after-free race condition in > TCP timers: > - Add a reference from tcpcb to its inpcb > - Defer tcpcb deletion until TCP timers have finished > --- > https://svnweb.freebsd.org/base?view=revision&revision=281599 > > First, I thought it was no possible as it touches struct > tcp_timer/struct tcpcb_mem. Second, John pointed me that these two > structures are used only internally. The only side effect I was able to > find is the increase of struct tcpcb_mem size: > > - stable/10: struct tcpcb_mem size is 1024 bytes > - stable/10 + tcp timer change: struct tcpcb_mem size is 1032 bytes > - currently in head: struct tcpcb_mem size is 1048 bytes > > If you have extra concerns on MFC-ing this change please scream. > Without nice yelps I plan to "MFC after: 1 month" (around May 16th). Following the lack of screamed concerns, here the MFC-ing result in stable/10 of the old and well-documented use-after-free TCP timer race condition fix: https://svnweb.freebsd.org/base?view=revision&revision=282964 Thanks again John for your inputs about the feasibility of this MFC. -- Julien [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVVeNhAAoJEKVlQ5Je6dhxpKsIAJIfQ5B6a19HSELTMxni/+6Z ElyDwV/62BO1OCUBaXj8WBCfUYF2hHqsWEL0xf12os5uovRqMBrzcC7qtE17lf3S 08LD2r1wje44YhvX1tdhKFw6WAh6c1Zst1kPjy4LiZEZ2xPETeBklXxBYS8Apx2W iJlwONBfcrUkm7INnOQYo6q/Mui9zfDk9JCxk5q3lk2c/dOYCItewWhH41OWKKu1 VuVGMLBOz2hiP3HGCrYrQ0mg46XnpZ+Fr6iR1JeaxpOyYKRb6C/tR/CO3prYD4JJ tkdOlBrfLKr8CmAlPeu2UQViDU48EJuIRZTWKIpi/SXLSq8qhGevt5rk8K2mozk= =QuOG -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5555E356.8080000>