Date: Wed, 12 Aug 2015 22:57:01 +0000 From: Glen Barber <gjb@FreeBSD.org> To: sbruno@freebsd.org Cc: freebsd-stable@freebsd.org Subject: Re: Possible Error in the FreeBSD 10.2 Release Notes/Man page for TCP Message-ID: <20150812225701.GE1460@FreeBSD.org> In-Reply-To: <55CBCEB2.9010009@ignoranthack.me> References: <131f8a0f25200031103639e969702727@dweimer.net> <20150812221546.GB1460@FreeBSD.org> <55CBCB91.9010301@ignoranthack.me> <20150812224338.GC1460@FreeBSD.org> <55CBCEB2.9010009@ignoranthack.me>
next in thread | previous in thread | raw e-mail | index | archive | help
--a1QUDc0q7S3U7/Jg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 12, 2015 at 03:54:42PM -0700, Sean Bruno wrote: > On 08/12/15 15:43, Glen Barber wrote: > > On Wed, Aug 12, 2015 at 03:41:21PM -0700, Sean Bruno wrote: > >> On 08/12/15 15:15, Glen Barber wrote: > >>> On Wed, Aug 12, 2015 at 01:09:31PM -0500, dweimer wrote: > >>>> I was reading through the Release notes, and decided to > >>>> enable net.inet.tcp.pmtud_blackhole_detection in my test > >>>> environment. It appears that the monitoring tunable=20 > >>>> net.inet.tcp.pmtud_blackhole_min_activated is incorrectly > >>>> listed. Using sysctl -a | grep net.inet.tcp.pmtud, doesn't > >>>> show it as a result. The test system is running RC3 built on > >>>> the 7th from revision 286391 of the > >>>> https://svn.freebsd.org/base/releng/10.2 tree. > >>>>=20 > >>>> root@freebsd:/usr/src # sysctl -a | grep net.inet.tcp.pmtud=20 > >>>> net.inet.tcp.pmtud_blackhole_mss: 1200=20 > >>>> net.inet.tcp.pmtud_blackhole_failed: 0=20 > >>>> net.inet.tcp.pmtud_blackhole_activated_min_mss: 0=20 > >>>> net.inet.tcp.pmtud_blackhole_activated: 0=20 > >>>> net.inet.tcp.pmtud_blackhole_detection: 1 > >>>>=20 > >>>> I did confirm that the pmtud_blackhole_min_activated option > >>>> is also listed in the tcp(4) man page page as well. > >>>>=20 > >>>> If anyone is more familiar with this than I am can they look > >>>> into seeing if there is indeed an error, or if I am missing > >>>> something here. > >>>>=20 > >>>=20 > >>> This appears to be an error based on the content of the commit=20 > >>> log. I will confirm with the person that committed the code, > >>> and will note the findings in the 10.2-RELEASE errata > >>> document. > >>>=20 > >>=20 > >> This looks like I failed to MFC r276345 to stable 10 in order to=20 > >> update tcp.4 leading to this confusion. > >>=20 > >=20 > > Thank you for confirming. I'll update the 10.2-RELEASE errata=20 > > accordingly. > >=20 > > What should the proper sysctls be, for completeness? > >=20 > > Glen > >=20 >=20 > % sysctl -a|grep pmtud > net.inet.tcp.v6pmtud_blackhole_mss: 1220 > net.inet.tcp.pmtud_blackhole_mss: 1200 > net.inet.tcp.pmtud_blackhole_failed: 0 > net.inet.tcp.pmtud_blackhole_activated_min_mss: 0 > net.inet.tcp.pmtud_blackhole_activated: 0 > net.inet.tcp.pmtud_blackhole_detection: 0 >=20 >=20 > These are correct. The man page is now updated as of svn r286706. >=20 Thank you. Glen --a1QUDc0q7S3U7/Jg Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVy889AAoJEAMUWKVHj+KTERgP/30SGD1C1AdE3rMBRGZ/T/2q 5356Mdz/gxUcpHy6cdsKJUit5ptpPaZPnpDKTr/KSIb37HhfWxYZQBDq/IF5/zE0 CQ1FrWLVvmSsiNB+32TxCumKF6bRPxtQFbsLhfC6nC9Q9khyRUxMTx1GzpH58ap9 B8JAq2Bs5j/O2i6x/HMORmdH41MXOf6v+n6pmP77YWmm3pRsPSIu1iJD0IdEn+N7 mvllK0anFVZs9kJ4b/VvtN7AFrvc/OhDu7GzInc8Af8T0WiDFCbfBvzSk0G0QuDx ez8lAZNsC5QY/lRLRVkrNpeGypZSNuFyMwF1Lt3O3CH32/TLNzeMOf1PMNp46wlg yRex8aBhJvo3I7+JdAbRX8hcayBxRwcLtPYWdP4i59PcvgiIpgAUnFsriDDbOeGd 6Ela+m1EoqSrm8wQ09siLtoKdSoa3EOThX9B3hCQFJreXh+l1VZqh2ChIH/fQp57 Fht2TN37eKopnp5aKMirEwZbK5xJGPXN9mXjpryKYG8+QTpAPAt6Tsp3KooMKW88 VE+IeYiA+uTVgrA9QddYf4Fi4BDx4uOfpXP0k8Pa4ZfITZRPWj7qnwMueOrZSK+R sIO+MKK6fk65KnR13elPfhgScIUOReW4/edhcA6+qkNFwoQ/LreWF3dmRLPiKEZo aao/GX0DHEU1bbaXgB+t =qkT4 -----END PGP SIGNATURE----- --a1QUDc0q7S3U7/Jg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150812225701.GE1460>