Date: Sat, 30 Jan 2016 18:26:18 +0100 From: Marius Strobl <marius@alchemy.franken.de> To: Mike Tancsa <mike@sentex.net> Cc: FreeBSD-STABLE Mailing List <freebsd-stable@freebsd.org> Subject: Re: possible em regression (was Re: svn commit: r294958 - in stable/10: share/man/man4 sys/dev/e1000 sys/dev/ixgb sys/dev/netmap) Message-ID: <20160130172618.GA15359@alchemy.franken.de> In-Reply-To: <56ACE917.80502@sentex.net> References: <201601272231.u0RMV8LW019394@repo.freebsd.org> <56ABAA92.5050901@sentex.net> <56ABB291.5040305@omnilan.de> <56ABCE95.3030807@sentex.net> <20160130012358.GY15359@alchemy.franken.de> <56ACE917.80502@sentex.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--9Iq5ULCa7nGtWwZS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Sat, Jan 30, 2016 at 11:47:19AM -0500, Mike Tancsa wrote:
> On 1/29/2016 8:23 PM, Marius Strobl wrote:
> > On Fri, Jan 29, 2016 at 03:41:57PM -0500, Mike Tancsa wrote:
> >>
> >> No multi queue. Stock GENERIC kernel with a couple of things removed.
> >> hw.em are just the defaults. I will try without TSO
> >>
> >> % ifconfig em0
> >> em0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
> >>
> >> options=4209b<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM,WOL_MAGIC,VLAN_HWTSO>
> >>
> >
> > Hrm, that's strange, TSO4 should be enabled by default so apparently
> > you are already disabling it; what is the behavior if you turn it on?
> > Do you use a < Gigabit link?
>
> Hi Marius,
> Thanks for looking. The ifconfig output was after I turned off tso as
> Harry suggested to try. Its been 24hrs and I have not seen any resets.
> I will wait another 36hrs or so and then turn it back on to see if the
> problem comes back.
>
> this link is 100Mb.
Ah, okay, that at least makes sense. Can you please verify that with
the attached patch applied, you have a setup that works out of the
box?
Marius
--9Iq5ULCa7nGtWwZS
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="em_tso_gig_only_10.diff"
Index: sys/dev/e1000/if_em.c
===================================================================
--- sys/dev/e1000/if_em.c (revision 294962)
+++ sys/dev/e1000/if_em.c (working copy)
@@ -1377,8 +1377,15 @@ em_init_locked(struct adapter *adapter)
ifp->if_hwassist = 0;
if (ifp->if_capenable & IFCAP_TXCSUM)
ifp->if_hwassist |= (CSUM_TCP | CSUM_UDP);
- if (ifp->if_capenable & IFCAP_TSO4)
- ifp->if_hwassist |= CSUM_TSO;
+ /*
+ ** There have proven to be problems with TSO when not
+ ** at full gigabit speed, so disable the assist automatically
+ ** when at lower speeds. -jfv
+ */
+ if (ifp->if_capenable & IFCAP_TSO4) {
+ if (adapter->link_speed == SPEED_1000)
+ ifp->if_hwassist |= CSUM_TSO;
+ }
/* Configure for OS presence */
em_init_manageability(adapter);
--9Iq5ULCa7nGtWwZS--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160130172618.GA15359>