Date: Wed, 04 Mar 2009 11:25:24 +0100 From: Alexander Leidinger <Alexander@Leidinger.net> To: Boris Samorodov <bsam@ipt.ru> Cc: freebsd-emulation@freebsd.org Subject: Re: [patch] Mk/bsd.linux-rpm.mk: introduce some linux-f8 infrastructure Message-ID: <20090304112524.45016b7uvodhvvok@webmail.leidinger.net> In-Reply-To: <79218247@bb.ipt.ru> References: <14905754@bb.ipt.ru> <20090304093137.10733oaty524f0is@webmail.leidinger.net> <11370520@bb.ipt.ru> <20090304103247.417765zrsapwwow0@webmail.leidinger.net> <79218247@bb.ipt.ru>
index | next in thread | previous in thread | raw e-mail
Quoting Boris Samorodov <bsam@ipt.ru> (from Wed, 04 Mar 2009 13:01:28 +0300): > Alexander Leidinger <Alexander@Leidinger.net> writes: >> Quoting Boris Samorodov <bsam@ipt.ru> (from Wed, 04 Mar 2009 >> 12:23:35 +0300): >>> Alexander Leidinger <Alexander@Leidinger.net> writes: >>>> Quoting Boris Samorodov <bsam@ipt.ru> (from Tue, 03 Mar 2009 >> >>>>> . define MASTER_SITE_SUBDIR and MASTER_SITE_SRC_SUBDIR when >>>>> LINUX_DIST_VER=8 (no such ports ATM). >>>> >>>> Why is there ifndef MASTER_SITES (only in the context of your patch, >>> >>> This ifndef was introduced by sat@ at Rev 1.9. I'm not aware of the >>> real need. >> >> I had a look at it. It is about protecting MASTER_SITE_* to be set, >> e.g. imagine if someone sets MASTER_SITE=file:///..., and at this >> location there's a flat file structure. In this case you do not want >> to have MASTER_SITE_* to be set. >> >> So I think you need to change your patch to keep this functionality. > > Yes, good catch, thanks! The first .endif was misplaced. Seems that > the following patch is what you meant: Yes, looks commit ready. Personally I would remove the '?' from MASTER_SITE?=, as it is handled by the ifndef. This way it does not confuse readers. MAybe even putting a comment there what this is all about. Bye, Alexander. -- Grelb's Reminder: Eighty percent of all people consider themselves to be above average drivers. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090304112524.45016b7uvodhvvok>