Date: Thu, 11 Sep 2025 07:44:11 -0600 From: Alan Somers <asomers@freebsd.org> To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@freebsd.org> Cc: Mark Millard <marklmi@yahoo.com>, FreeBSD Current <freebsd-current@freebsd.org>, Konstantin Belousov <kib@freebsd.org> Subject: Re: git: d549de769055 - main - libc: Remove readdir_r(3) [This broke building rust 1.88] Message-ID: <CAOtMX2gJJ-wGtK3%2BQwyz_eODYWK6pwaMA6gbnN74Pvqc1QW6Mw@mail.gmail.com> In-Reply-To: <86bjnhi7s2.fsf@ltc.des.dev> References: <1F6A4621-1505-4F78-97C6-85EA556B2165@yahoo.com> <86bjnhi7s2.fsf@ltc.des.dev>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Thu, Sep 11, 2025 at 4:49 AM Dag-Erling Smørgrav <des@freebsd.org> wrote: > Mark Millard <marklmi@yahoo.com> writes: > > Example error message text from the log file for the > > rust build via poudriere-devel: > > > > > > = note: ld: error: undefined symbol: readdir_r > > >>> referenced by std.d8968a002452916e-cgu.07 > > >>> > std-de94806a57729acc.std.d8968a002452916e-cgu.07.rcgu.o:(std::sys::fs::unix::remove_dir_impl::remove_dir_all_recursive::hbe1160129d2c5f7c) > > >>> in archive /wrkdirs/usr/ports/lan > > > g/rust/work/bootstrap/lib/rustlib/x86_64-unknown-freebsd/lib/libstd-de94806a57729acc.rlib > > >>> did you mean: readdir_r@FBSD_1.5 > > >>> defined in: /lib/libc.so.7 > > cc: error: linker command failed with exit code 1 (use -v to > see invocation) > > Tell that to the Rust developers. They have been repeatedly warned > against using readdir_r(3) for years, as far back as 2016. > Have they? Looking at rust's github page, I see discussions about using readdir_r on Fuchsia and Linux, but nothing about BSD. But even if they have been "warned", that's not really relevant. We shouldn't cavalierly break the build for such important software. I'm guessing that you didn't do an exp-run for this change, so there is probably other software in ports that is broken, too. I request that this change be reverted. And I request that it remain reverted until such a time as an exp-run passes, possibly with the aid of installing misc/compat14x as a dependency for some ports. [-- Attachment #2 --] <div dir="ltr"><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Thu, Sep 11, 2025 at 4:49 AM Dag-Erling Smørgrav <<a href="mailto:des@freebsd.org">des@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Mark Millard <<a href="mailto:marklmi@yahoo.com" target="_blank">marklmi@yahoo.com</a>> writes:<br> > Example error message text from the log file for the<br> > rust build via poudriere-devel:<br> ><br> ><br> > = note: ld: error: undefined symbol: readdir_r<br> > >>> referenced by std.d8968a002452916e-cgu.07<br> > >>> std-de94806a57729acc.std.d8968a002452916e-cgu.07.rcgu.o:(std::sys::fs::unix::remove_dir_impl::remove_dir_all_recursive::hbe1160129d2c5f7c)<br> > >>> in archive /wrkdirs/usr/ports/lan<br> > g/rust/work/bootstrap/lib/rustlib/x86_64-unknown-freebsd/lib/libstd-de94806a57729acc.rlib<br> > >>> did you mean: readdir_r@FBSD_1.5<br> > >>> defined in: /lib/libc.so.7<br> > cc: error: linker command failed with exit code 1 (use -v to see invocation)<br> <br> Tell that to the Rust developers. They have been repeatedly warned<br> against using readdir_r(3) for years, as far back as 2016.<br></blockquote><div><br></div><div>Have they? Looking at rust's github page, I see discussions about using readdir_r on Fuchsia and Linux, but nothing about BSD. But even if they have been "warned", that's not really relevant. We shouldn't cavalierly break the build for such important software. I'm guessing that you didn't do an exp-run for this change, so there is probably other software in ports that is broken, too. I request that this change be reverted. And I request that it remain reverted until such a time as an exp-run passes, possibly with the aid of installing misc/compat14x as a dependency for some ports.</div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2gJJ-wGtK3%2BQwyz_eODYWK6pwaMA6gbnN74Pvqc1QW6Mw>