Date: Mon, 7 Mar 2016 20:19:46 +0100 From: Matthieu Volat <mazhe@alkumuna.eu> To: ashish@FreeBSD.org (Ashish SHUKLA) Cc: ports-list freebsd <freebsd-ports@freebsd.org> Subject: Re: [CFT] net-im/ejabberd to 16.01 Message-ID: <20160307201946.0964505f@freedom.alkumuna.eu> In-Reply-To: <86io0yzsfs.fsf@chateau.d.if> References: <86h9gs26l0.fsf@chateau.d.if> <20160228193353.0b62c06b@freedom.alkumuna.eu> <864mcs1g9p.fsf@chateau.d.if> <CEC1F737-32E1-478D-A3AB-3473BF14B28F@alkumuna.eu> <86d1rfehpi.fsf@chateau.d.if> <20160305180935.1eff68ff@freedom.alkumuna.eu> <86io0yzsfs.fsf@chateau.d.if>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, 07 Mar 2016 12:27:11 +0530 ashish@FreeBSD.org (Ashish SHUKLA) wrote: > On Sat, 5 Mar 2016 18:09:35 +0100, Matthieu Volat <mazhe@alkumuna.eu> said: > > [...] > > Hi, > > | Ok, back on business! > > | My issue with the non-applied patchs is that those were not creates in the files subdir in ejabberd, but in a ejabberd/files subdir. > > That is likely due to the missing/incorrect, use of 'patch -pN'. I remember > testing successful diff application before posting on the list, except for a > 404-ing URL in one of my diffs. Yeah, it was a simple patch -p0 call... But anyway, that won't matter for final distribution... > > | Regarding the pam module installation, it seems to be installed in : > | /usr/local/lib/erlang/lib/ejabberd-16.01/lib/p1_pam-1.0.0/priv/bin/epam > > | But ejabberd at start will fail with : > | 2016-03-05 17:52:49.297 [error] <0.394.0> Can't open file > | "/usr/local/lib/erlang/lib/ejabberd-16.01/lib/erlang/lib/ejabberd-16.01/priv/bin/epam": enoent > > | So I guess it's not installed in the right place? > > I guess, although I don't see in the sources, where exactly it refer to this > path, or even install the module. I'll check and get back to you. I forgot to tell that I did not see it either, but I tried to put it manually and pam support was working. > > | Then, regarding the bash issue, I made some progress, but I still need > | to test it a bit more to be sure it do not introduce new bugs (it's > | not much, but I have to see if the kinda simple shell escaping > | function equivalent I put is enough). > > These bash script changes could you contribute to upstream instead. I don't > really wish to keep maintaining them downstream. I agree. > > ejabberd team has released 16.02 in the meantime, I'll work on updating to it > instead. It works fine in my testing so far except for the PAM issue you've > mentioned. > > I'll post updated patch here for testing. > > Thanks! > -- > Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0 > > “If I were to compare a human's heart with the ocean, the ocean would be > stagnant.” (Recruit, Arakawa Under the Bridge) > > Sent from my Emacs -- Matthieu Volat <mazhe@alkumuna.eu> tel: 06 84 54 39 43 www: <http://500px.com/Mazhe>; [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlbd1FIACgkQ+ENDeYKZi34h9wCgyBh3bRxzo0U9WBLlwZXJrfkx H0kAn2ELIxfy4Ts0F46AqWXkngoNkNQR =lWrM -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160307201946.0964505f>