Date: Thu, 7 Apr 2022 18:56:48 +0200 From: Mario Marietto <marietto2008@gmail.com> To: Rebecca Cran <rebecca@bsdio.com> Cc: =?UTF-8?Q?Corvin_K=C3=B6hne?= <C.Koehne@beckhoff.com>, Peter Grehan <grehan@freebsd.org>, devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>, Jiewen Yao <jiewen.yao@intel.com>, Jordan Justen <jordan.l.justen@intel.com>, FreeBSD Virtualization <freebsd-virtualization@freebsd.org>, Gerd Hoffmann <kraxel@redhat.com> Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg Message-ID: <CA%2B1FSiiYSVb1ZJYXQURpDNUe-qY9Bm_hvC6iGak_M465nP%2BPiQ@mail.gmail.com> In-Reply-To: <8dc8c192-1bc6-71cc-d572-eda275724e99@bsdio.com> References: <20220329101417.617-1-c.koehne@beckhoff.com> <b799a8e3f6de41eca391124ae553deec@beckhoff.com> <dc7769bd-372c-8d57-c683-ad845359b318@bsdio.com> <c6087bea-ed0e-ba94-4f58-ada1bf049ad2@freebsd.org> <7cdf6ac12fbc499fb846f85782d06e21@beckhoff.com> <8dc8c192-1bc6-71cc-d572-eda275724e99@bsdio.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000d3b0b905dc135d30 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable im trying to test the patch on my pc,that has two graphic cards,the intel coffee lake and the nvidia. i tried to start the pc from the nvidia card and ive configured the xorg.conf file giving the proper bus id value. in addition ive loaded the kernel.ko file from the boot loader.conf i have removed the intel and the drm drivers used by the Intel graphic card. unfortunately my pc wont boot from the nvidia card. my mouse and keyboard freezes just before the desktop manager (xfce and kde5) starts. Il gio 7 apr 2022, 18:46 Rebecca Cran <rebecca@bsdio.com> ha scritto: > I've just looked at the patch and it looks good, though I haven't tested > it. > > So yes, please add: > > > Acked-by: Rebecca Cran <rebecca@bsdio.com> > > > On 4/6/22 23:24, Corvin K=C3=B6hne wrote: > > Hi Peter and Rebecca, > > > > thanks for your feedback. This patch is backward compatible. It checks > > if QemuFwCfg is available and if QemuFwCfg is missing it falls > > back to BhyveFwCtl. > > > > So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the > > commit message? > > > > > > Thanks > > Corvin > > > > Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans > Beckhoff > > Registered office: Verl, Germany | Register court: Guetersloh HRA 7075 > > > > > > > > --000000000000d3b0b905dc135d30 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto">im trying to test the patch on my pc,that has two graphic= cards,the intel coffee lake and the nvidia. i tried to start the pc from t= he nvidia card and ive configured the xorg.conf file giving the proper bus = id value. in addition ive loaded the kernel.ko file from the boot loader.co= nf i have removed the intel and the drm drivers used by the Intel graphic c= ard. unfortunately my pc wont boot from the nvidia card. my mouse and keybo= ard freezes just before the desktop manager (xfce and kde5) starts.</div><b= r><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">Il gio 7= apr 2022, 18:46 Rebecca Cran <<a href=3D"mailto:rebecca@bsdio.com">rebe= cca@bsdio.com</a>> ha scritto:<br></div><blockquote class=3D"gmail_quote= " style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I= 've just looked at the patch and it looks good, though I haven't te= sted it.<br> <br> So yes, please add:<br> <br> <br> Acked-by: Rebecca Cran <<a href=3D"mailto:rebecca@bsdio.com" target=3D"_= blank" rel=3D"noreferrer">rebecca@bsdio.com</a>><br> <br> <br> On 4/6/22 23:24, Corvin K=C3=B6hne wrote:<br> > Hi Peter and Rebecca,<br> ><br> > thanks for your feedback. This patch is backward compatible. It checks= <br> > if QemuFwCfg is available and if QemuFwCfg is missing it falls<br> > back to BhyveFwCtl.<br> ><br> > So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the<b= r> > commit message?<br> ><br> ><br> > Thanks<br> > Corvin<br> ><br> > Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys.= Hans Beckhoff<br> > Registered office: Verl, Germany | Register court: Guetersloh HRA 7075= <br> ><br> ><br> ><br> <br> </blockquote></div> --000000000000d3b0b905dc135d30--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2B1FSiiYSVb1ZJYXQURpDNUe-qY9Bm_hvC6iGak_M465nP%2BPiQ>