Date: Mon, 28 Feb 2011 19:15:25 +0530 From: ashish@FreeBSD.org (Ashish SHUKLA) To: Marius =?utf-8?Q?N=C3=BCnnerich?= <marius@nuenneri.ch> Cc: Ashish SHUKLA <ashish@freebsd.org>, freebsd-ports@freebsd.org Subject: Re: pdnsd leaking udp sockets Message-ID: <86k4gkxoga.fsf@chateau.d.if> In-Reply-To: <AANLkTi=E71UEJDLB5Yc0kEqpfx0TW2=YrSzhJb_ngS7t@mail.gmail.com> ("Marius =?utf-8?Q?N=C3=BCnnerich=22's?= message of "Mon, 28 Feb 2011 13:42:15 %2B0100") References: <AANLkTimtGzJSXDGG8JeOvuUWEEMXoKP6JN13CRFu6Cdn@mail.gmail.com> <86bp2d1wit.fsf@chateau.d.if> <AANLkTin=8BN6rEVH=XSFPFS7DZmxvTPZvqzK=912dhOY@mail.gmail.com> <86oc6dzf1z.fsf@chateau.d.if> <AANLkTi=T_KLA9mPxzWufGKUuTf4Q2dAm0w59Z9%2BNdbOo@mail.gmail.com> <86lj1ah2ce.fsf@chateau.d.if> <AANLkTi=E71UEJDLB5Yc0kEqpfx0TW2=YrSzhJb_ngS7t@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Marius N=C3=BCnnerich writes: > On Sun, Feb 20, 2011 at 21:34, Ashish SHUKLA <ashish@freebsd.org> wrote: >> Hi Marius, >>=20 >> Marius N=C3=BCnnerich writes: >>=20 >> [...] >>=20 >>> Ok, I applied the patch and reinstalled the port. I will leave it >>> running for a few days and report back. So far it's looking good. >>> Thank you very much! :) >>=20 > OK, I had it running for a while now with your fix. It's not leaking anym= ore. > There is still one close() missing before a return in that same function. Yes, you're right. I've updated the original diff[1] in case someone like t= o try it. I'll commit it in a day or two. >> I talked to Paul (the upstream author of pdnsd), and he suggested running >> dns/pdnsd with following command-line (requires devel/valgrind port): >>=20 >> % valgrind --tool=3Dmemcheck --leak-check=3Dyes --track-fds=3D=3Dyes pdn= sd --nodaemon > I'll try this too if I can find the time, but so far it doesn't seem > to leak memory. Cool. References: [1] http://people.freebsd.org/~ashish/diffs/pdnsd-sockets-leak.diff Thanks =2D-=20 Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0 freebsd.org!ashish | http://people.freebsd.org/~ashish/ Avoid Success At All Costs !! --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iQIcBAEBCgAGBQJNa6b6AAoJEMdGz6nnT6Sw5NsP/jCgMbYrrpWkzsJb9z+eunf3 kp1w7BJSC+YJA4pZ+QZf6hR4tFMJQlmddWQ1hkxe19jEzQop/UAxWxTsbGjPWhD+ m8V3e4hoyYfLyE7Nk5goSATPUnEbeBRaZP1+PsI/7qwzpIX5M7nI0wM9wZl3eA0p ljxtXu3O2g7tTh63i51OoqNVDiykN0CjqxpVRPcVKyuwYDIYfELPvbo1DjUIXGVx huR4gZUf7BJmUNlrCOb7la1t09FDiFcTXCBYDVp/awVQCp16SB1I6KrUVK5Ij6wB kc6fjcms2aJNaMC3h1w+hmmtG4BL4rAD6oOkpQ0KvBxGuUOvjeUZDyKV8PKcR1D5 V6kj4vMhPvXrxmbE0elJVEN98PllZVf9R3asVuc4Zkf+V00aUP68qQTLlxOj3L2s SGww1S6QXv9Nb9GRZ1E+p0bPKUt8qCeMmaWq/ksJUKBQWoo7rS5vn1KW8EivgiDV CIRjUSK4SuUqDoDYJrJATMmZDyzDoIn1NaPr36nLMyE2wSjMS++aR3eUgbvSu8dm xWvOEliHki+fSJK7iqxf1WICfKnm9NycfvOAce+EYFDQXpl/CX7MKXImEygncDnx htu5WBjEquH6NgN/UyaeE+arBazNnKPQBiSaZK+9wGHUaUUOrG5Hs9r9J1HyuMPF Qa3nwhXBSUclzGXUqT9t =1q+X -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86k4gkxoga.fsf>