Date: Thu, 22 Oct 2009 03:16:56 +0000 From: "b. f." <bf1783@googlemail.com> To: "Li, Qing" <qing.li@bluecoat.com> Cc: freebsd-current@freebsd.org Subject: Re: svn commit: r198306 - head/sys/net Message-ID: <d873d5be0910212016qea39846v45a3ddd21ee45d55@mail.gmail.com> In-Reply-To: <B583FBF374231F4A89607B4D08578A4305AE913E@bcs-mail03.internal.cacheflow.com> References: <d873d5be0910201621h768e126dq34df38c07b83fe47@mail.gmail.com> <bc2d970910201734o332582ceic30fb7e42e14c812@mail.gmail.com> <d873d5be0910201900w67833e83kf53b556e2b5c8d00@mail.gmail.com> <bc2d970910202030u2c03571etb6379cf29260617d@mail.gmail.com> <9ace436c0910202052r1d1235dax774290a4fa1ee842@mail.gmail.com> <B583FBF374231F4A89607B4D08578A4305AE913E@bcs-mail03.internal.cacheflow.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/21/09, Li, Qing <qing.li@bluecoat.com> wrote:
> I reviewed the SMP code and architecture modules last night. After
> discussion
> with Kip Macy, we feel using the "#ifdef SMP" is actually not necessary
> here.
>
Perhaps not strictly necessary, but wouldn't it be better to have it?
What is your rationale for not using making it conditional on SMP? I
note that these will be the only such unconditional uses of that
variable that I see in the tree, other than the definition in
sys/sys/smp.h.
Regards,
b.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d873d5be0910212016qea39846v45a3ddd21ee45d55>