Date: Thu, 9 Jul 2015 16:11:29 +0200 From: =?UTF-8?Q?Ermal_Lu=C3=A7i?= <eri@freebsd.org> To: Rink Springer <rink@freebsd.org> Cc: "freebsd-current@freebsd.org" <freebsd-current@freebsd.org> Subject: Re: panic: negative refcount after dhclient during boot Message-ID: <CAPBZQG14oZ37zCGZDNOpv8ahyVYQ3hHngz266bHcKE%2B06w52-A@mail.gmail.com> In-Reply-To: <CAPBZQG2REY4GZw-OVDq6MBqxi5Z3wv86EgbKu2k1mRasbBEpFQ@mail.gmail.com> References: <20150705151541.GC45822@rink.nu> <BC02FB25-32CA-41A6-8730-9D630C988566@gmail.com> <20150706072154.GA86301@rink.nu> <20150707161107.GE86301@rink.nu> <CAPBZQG2REY4GZw-OVDq6MBqxi5Z3wv86EgbKu2k1mRasbBEpFQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 8, 2015 at 5:09 PM, Ermal Lu=C3=A7i <eri@freebsd.org> wrote: > > > On Tue, Jul 7, 2015 at 6:11 PM, Rink Springer <rink@freebsd.org> wrote: > >> Hi eri@, >> >> On Mon, Jul 06, 2015 at 09:21:54AM +0200, Rink Springer wrote: >> > On Sun, Jul 05, 2015 at 12:45:25PM -0700, Garrett Cooper wrote: >> > > On Jul 5, 2015, at 8:16, Rink Springer <rink@freebsd.org> wrote: >> > > >> > > > Hi all, >> > > > >> > > > On my FreeBSD/mips machine (it's a RouterStation Pro), I get the >> > > > following panic during boot: >> > > >> > > ? >> > > >> > > > This reproduces 100%. I'm at: >> > > > >> > > > FreeBSD 11.0-CURRENT #0 r285099: Sun Jul 5 12:31:47 CEST 2015 >> > > > >> > > > Let me know what I can do to help track this down; I only started >> > > > getting the panic after 'gateway_enable=3DYES' in /etc/rc.conf >> > > > >> > > > The kernel has INVARIANTS but no WITNESS. Config available at >> > > > http://rink.nu/tmp/FRINGE - boot log at >> http://rink.nu/tmp/fringe.txt >> > > >> > > Please file a bug! >> > >> > Done, 201371. >> >> After a suggestion by adrian@, it seems reverting r285051 fixes the >> problem for me (i.e. the system boots now) >> >> > Can you please try with this patch and let me know if it fixes the issue. > > Index: sys/netinet/ip_output.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/netinet/ip_output.c (revision 285271) > +++ sys/netinet/ip_output.c (working copy) > @@ -660,6 +660,13 @@ > done: > if (ro =3D=3D &iproute) > RO_RTFREE(ro); > + else if (rte =3D=3D NULL) > + /* > + * If the caller supplied a route but somehow the referen= ce > + * to it has been released need to prevent the caller > + * calling RTFREE on it again. > + */ > + ro->ro_rt =3D NULL; > if (have_ia_ref) > ifa_free(&ia->ia_ifa); > return (error); > > >> Regards, >> Rink > > Actually this is the correct fix apparently. https://reviews.freebsd.org/D3036 --=20 Ermal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPBZQG14oZ37zCGZDNOpv8ahyVYQ3hHngz266bHcKE%2B06w52-A>