Date: Mon, 24 Mar 1997 10:03:54 -0700 From: Warner Losh <imp@village.org> To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.ru> Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/stdtime localtime.c Message-ID: <E0w9DA2-0005II-00@rover.village.org> In-Reply-To: Your message of "Mon, 24 Mar 1997 19:25:28 %2B0300." <Pine.BSF.3.95q.970324192251.2099C-100000@nagual.ru> References: <Pine.BSF.3.95q.970324192251.2099C-100000@nagual.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <Pine.BSF.3.95q.970324192251.2099C-100000@nagual.ru> =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= writes: : I forget to note that this change should be backed out in any case. : It broke whole TZ idea. If you need check, do it properly checking : ranges and overflowes inside localtime code itself, not by disallowing : tz file opening. Ummm, my tests show that it works with all standard TZ values (at least the ones I samples EST, EST5EDT, America/New_York). It didn't work with /home/imp/bogus/time/zone, which was the intent of the change. If my tests were flawed, then please let me know what I broke. I tested this with a setuid copy of date. Any my commit message was horrible in that it cause confusion. All I intended to do was to disallow non-standard places. If that isn't the case, please let me know. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E0w9DA2-0005II-00>