Date: Thu, 24 Oct 2002 13:59:54 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: John Baldwin <jhb@FreeBSD.org> Cc: Mark Murray <markm@FreeBSD.org>, <cvs-all@FreeBSD.org>, <cvs-committers@FreeBSD.org> Subject: RE: cvs commit: src/usr.bin/systat swap.c Message-ID: <20021024135408.B25683-100000@gamplex.bde.org> In-Reply-To: <XFMail.20021023152052.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 23 Oct 2002, John Baldwin wrote: > On 23-Oct-2002 Mark Murray wrote: > > markm 2002/10/23 12:02:17 PDT > > > > Modified files: > > usr.bin/systat swap.c > > Log: > > Adjust for getbsize argument type change. > > Ignoring ABI breakage doesn't make it go away. If you think the > ABI breakage is in a routine no non-system programs use and that > it won't break 4.x -> 5.0 upgrades then say that. Otherwise you > might need to look into another way to work around this. The > fact that the only old platforms (alpha and i386) are both > little endian may make this specific breakage not quite as bad. Both this and the changes in pstat/pstat.c are better examples than the changes in df.c that this is not just ABI breakage. It also requires kludges in all clients to convert the type back to the correct one. That the original change is not even wrong should have been obvious if all of the clients in at least usr/src were broken to be compatible with it before it was committed. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021024135408.B25683-100000>