Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Sep 1997 22:31:30 +0200
From:      Stefan Esser <se@FreeBSD.ORG>
To:        Simon Shapiro <Shimon@i-connect.net>
Cc:        freebsd-current@FreeBSD.ORG
Subject:   Re: Warning in pci_compat.c
Message-ID:  <19970910223130.58665@mi.uni-koeln.de>
In-Reply-To: <XFMail.970910112205.Shimon@i-Connect.Net>; from Simon Shapiro on Wed, Sep 10, 1997 at 11:22:05AM -0700
References:  <XFMail.970910112205.Shimon@i-Connect.Net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sep 10, Simon Shapiro <Shimon@i-connect.net> wrote:
> This is another one.  From a different area.  Again, do we have to suffer
> this indignation? :-)
> 
> cc -c -O -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit 
> -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes  -Wpointer-arith 
> -nostdinc -I- -I. -I../.. -I../../../include -DEXT2FS -DFAILSAFE -DSAFETY
> -DUMAPFS_DIAGNOSTIC -DKERNFS_DIAGNOSTIC -DNULLFS_DIAGNOSTIC -DDEVFS -DNFS
> -DFFS -DTCPDEBUG -DIPDIVERT -DINET -DCOMPAT_43 -DKERNEL -include
> opt_global.h  ../../pci/pci_compat.c
> .../../pci/pci_compat.c: In function `pci_map_int':
> .../../pci/pci_compat.c:172: warning: passing arg 3 of `intr_create' from
> incompatible pointer type

Yes, we have have to suffer ... :)

The interrupt handler had been defined differently
for different bus types. We should (IMHO) have:

void inthandler(void*);

But ISA handlers are called with a unit number, and
PCI handlers used to return an int ...

Regards, STefan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19970910223130.58665>