Date: Sun, 16 Sep 2012 19:34:26 +0200 From: Gabor Kovesdan <gabor@FreeBSD.org> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: freebsd-www@freebsd.org Subject: Re: [Request for Review] Where to put SA texts and patches? Message-ID: <50560DA2.1040803@FreeBSD.org> In-Reply-To: <alpine.BSF.2.00.1209161659230.13080@ai.fobar.qr> References: <alpine.BSF.2.00.1208121712350.4474@ai.fobar.qr> <20120812172415.GB1301@glenbarber.us> <alpine.BSF.2.00.1208191133350.78446@ai.fobar.qr> <alpine.BSF.2.00.1209161659230.13080@ai.fobar.qr>
next in thread | previous in thread | raw e-mail | index | archive | help
Em 16-09-2012 19:00, Bjoern A. Zeeb escreveu: > based on some feedback I got back then to centralize SYMLINKS handling > I also factored out hte BULKDATA stuff. The new patch (which I'd love > to sommit really soon), can be found here: > > http://people.freebsd.org/~bz/20120916-01-dsvn-security.diff Thanks for taking the time to refactor it, it looks much better! One more nit which I'd suggest is to make BULKDATADIR recursive by default, that is, if you set BULKDATADIR=patches, it should install patches recursively without having to manually deal with the subdirectories. I think it's the logical behavior and it would be better to hide that logic in the .mk file. Imo, it can easily be done with for cycles and find(1). Gabor
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50560DA2.1040803>