Date: Fri, 2 Apr 2010 17:40:58 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: =?ISO-8859-1?Q?Ermal_Lu=E7i?= <ermal.luci@gmail.com> Cc: freebsd-net <freebsd-net@freebsd.org> Subject: Re: Is this correct? Message-ID: <20100402173951.K40281@maildrop.int.zabbadoz.net> In-Reply-To: <s2j9a542da31004021029u531d4955u9fa1a1f892e0e63f@mail.gmail.com> References: <9a542da31003190453s1e7598efr8f35f525871f5589@mail.gmail.com> <20100402170740.N40281@maildrop.int.zabbadoz.net> <s2j9a542da31004021029u531d4955u9fa1a1f892e0e63f@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Fri, 2 Apr 2010, Ermal Luçi wrote:
Hi,
>>> Shouldn't this check be
>>> if (m->m_len > sizeof (struct ip)) {
>>> instead of
>>> if (m->m_len < sizeof (struct ip)) {
>>
>> Should it be > or >= ?
>>
> I would say >= since that is what logic assumes!
Yeah. Commit that.
/bz
--
Bjoern A. Zeeb It will not break if you know what you are doing.
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100402173951.K40281>