Date: Mon, 20 Jan 2025 18:28:02 +0100 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Pietro Cerutti <gahr@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 98582ae673d8 - main - mail/opensmtpd-table-sqlite: new port Message-ID: <0cfa09977d44f4345dc26dfc3b29dd34@mail.infomaniak.com> In-Reply-To: <nsyzvtp3rsebmdrb6l2a7cczoy4ppnpbb7eebaddkisjcp6nl6@wixgqtyujuw7> References: <202501191231.50JCVTKv086950@gitrepo.freebsd.org> <ac65f490714ba45edd9ef5557efa6b9b@mail.infomaniak.com> <nsyzvtp3rsebmdrb6l2a7cczoy4ppnpbb7eebaddkisjcp6nl6@wixgqtyujuw7>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2025-01-20T14:19:50.000+01:00, Pietro Cerutti <gahr@FreeBSD.org> wrote: > On Jan 19 2025, 13:03 +0000, Daniel Engberg <daniel.engberg.lists@pyret.net> wrote: > > [-- Type: text/plain; charset=utf-8, Encoding: quoted-printable, Size: 7.6K --] >> On 2025-01-19T13:31:40.000+01:00, Pietro Cerutti >> <gahr@FreeBSD.org> >> >> wrote: >> >>> The branch main has been updated by gahr: >>> >>> URL: >>> https://cgit.FreeBSD.org/ports/commit/?id=98582ae673d871b51f1c0b6b7cafb35879c02efc >>> >>> commit 98582ae673d871b51f1c0b6b7cafb35879c02efc >>> >>> Author: Pietro Cerutti <gahr@FreeBSD.org> >>> >>> AuthorDate: 2025-01-19 12:25:14 +0000 >>> >>> Commit: Pietro Cerutti <gahr@FreeBSD.org> >>> >>> CommitDate: 2025-01-19 12:31:27 +0000 >>> >>> mail/opensmtpd-table-sqlite: new port >>> >>> This port replaces mail/opensmtpd-extras-table-sqlite. >>> >>> The opensmtpd-extras-table-* ports got broken by the latest >>> update of >>> >>> OpenSMTPD, see my message on the mailing list: >>> >>> https://lists.freebsd.org/archives/dev-commits-ports-main/2025-January/134537.html >>> >>> I have requested action by fluffy@ both on the message linked >>> above and >>> >>> privately via email, but I haven't got any response back. >>> >>> At this point, I want to unblock my workflow and be able to >>> upgrade >>> >>> OpenSMTPD. I don't have plans to provide alternatives to all >>> the >>> >>> opensmtpd-extras-table-* ports. >>> >>> --- >>> >>> mail/Makefile | 1 + >>> >>> mail/opensmtpd-table-sqlite/Makefile | 26 >>> ++++++++++++++++++++++++++ >>> >>> mail/opensmtpd-table-sqlite/distinfo | 5 +++++ >>> >>> mail/opensmtpd-table-sqlite/pkg-descr | 2 ++ >>> >>> 4 files changed, 34 insertions(+) >>> >>> diff --git a/mail/Makefile b/mail/Makefile >>> >>> index 7fc7b579932a..09a72821dd5f 100644 >>> >>> --- a/mail/Makefile >>> >>> +++ b/mail/Makefile >>> >>> @@ -290,6 +290,7 @@ >>> >>> SUBDIR += opensmtpd-extras-table-sqlite >>> >>> SUBDIR += opensmtpd-filter-rspamd >>> >>> SUBDIR += opensmtpd-filter-senderscore >>> >>> + SUBDIR += opensmtpd-table-sqlite >>> >>> SUBDIR += osbf-lua >>> >>> SUBDIR += ovs >>> >>> SUBDIR += p5-CGP-CLI >>> >>> diff --git a/mail/opensmtpd-table-sqlite/Makefile >>> b/mail/opensmtpd-table-sqlite/Makefile >>> >>> new file mode 100644 >>> >>> index 000000000000..dfd64f7c1ecf >>> >>> --- /dev/null >>> >>> +++ b/mail/opensmtpd-table-sqlite/Makefile >>> >>> @@ -0,0 +1,26 @@ >>> >>> +PORTNAME= opensmtpd-table-sqlite >>> >>> +DISTVERSION= 1.0.1 >>> >>> +CATEGORIES= mail >>> >>> + >>> >>> +PATCH_SITES= https://github.com/OpenSMTPD/table-sqlite/commit/ >>> >>> +PATCHFILES= f3c46da1cbbb2a9d32cd9b4cf31e9fdb5b941a16.patch:-p1 >>> >>> + >>> >>> +MAINTAINER= gahr@FreeBSD.org >>> >>> +COMMENT= SQLite table for OpenSMTPD >>> >>> +WWW= https://github.com/opensmtpd/table-sqlite >>> >>> + >>> >>> +LICENSE= ISCL >>> >>> + >>> >>> +USES= autoreconf localbase sqlite >>> >>> +GNU_CONFIGURE= yes >>> >>> + >>> >>> +PATCH_ARGS= -p1 >>> >>> + >>> >>> +USE_GITHUB= yes >>> >>> +GH_ACCOUNT= opensmtpd >>> >>> +GH_PROJECT= table-sqlite >>> >>> + >>> >>> +PLIST_FILES= libexec/smtpd/table-sqlite \ >>> >>> + share/man/man5/table-sqlite.5.gz >>> >>> + >>> >>> +.include <bsd.port.mk> [http://bsd.port.mk>]; >>> [http://bsd.port.mk> [http://bsd.port.mk>];]; >>> >>> diff --git a/mail/opensmtpd-table-sqlite/distinfo >>> b/mail/opensmtpd-table-sqlite/distinfo >>> >>> new file mode 100644 >>> >>> index 000000000000..f19d8caf3cda >>> >>> --- /dev/null >>> >>> +++ b/mail/opensmtpd-table-sqlite/distinfo >>> >>> @@ -0,0 +1,5 @@ >>> >>> +TIMESTAMP = 1737289442 >>> >>> +SHA256 (opensmtpd-table-sqlite-1.0.1_GH0.tar.gz) = >>> 74f40788aec40087235cb82391ad21ed4aeb6d79dd7a0e89571f398825b653b0 >>> >>> +SIZE (opensmtpd-table-sqlite-1.0.1_GH0.tar.gz) = 21718 >>> >>> +SHA256 (f3c46da1cbbb2a9d32cd9b4cf31e9fdb5b941a16.patch) = >>> 0256ee0d826543e4ae4263f05c6ddedc635f72a713f34592663e4dbdd40e6d6c >>> >>> +SIZE (f3c46da1cbbb2a9d32cd9b4cf31e9fdb5b941a16.patch) = 1552 >>> >>> diff --git a/mail/opensmtpd-table-sqlite/pkg-descr >>> b/mail/opensmtpd-table-sqlite/pkg-descr >>> >>> new file mode 100644 >>> >>> index 000000000000..ede5705d7728 >>> >>> --- /dev/null >>> >>> +++ b/mail/opensmtpd-table-sqlite/pkg-descr >>> >>> @@ -0,0 +1,2 @@ >>> >>> +The SQLite table addon for OpenSMTPD allows the storing of >>> usernames, >>> >>> +passwords, aliases, and domains in a sqlite3 table. >> >> Hi, >> >> Any reason why you're not using upstream's release archive? >> >> That gets rid of patching and USES= autoreconf and you probably >> also >> >> want USES= localbase:ldflags instead of localbase . Looking at >> Porters >> >> Handbook you should likely also make use of PKGNAMEPREFIX instead >> of >> >> having opensmtpd- in PORTNAME. > > Using the release archive won't make the patch useless. Localbase is > > > enough, no need for ldflags. I don't see the point of using > > PKGNAMEPREFIX. > >> PATCH_ARGS is also unnecessary as you've set -p1 already. > > True, I'll do it when I need to commit the port next. > > -- > > Pietro Cerutti > > I have pledged to give 10% of income to effective charities > > and invite you to join me - https://givingwhatwecan.org Hi, You don't need the patch as it's already applied? As for LDLAGS vs LIBS, the configure script itself mentions that LDFLAGS should be used for the specific fix? "LDFLAGS linker flags, e.g. -L<lib dir> if you have libraries in a nonstandard directory <lib dir>" vs "LIBS libraries to pass to the linker, e.g. -l<library>" Using PKGNAMEPREFIX avoids you hacking around upstream's project name in ports. Best regards, Daniel [-- Attachment #2 --] <html><body><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">On 2025-01-20T14:19:50.000+01:00, Pietro Cerutti <gahr@FreeBSD.org> wrote:<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>On Jan 19 2025, 13:03 +0000, Daniel Engberg <<a class="defaultMailLink" href="mailto:daniel.engberg.lists@pyret.net">daniel.engberg.lists@pyret.net</a>> wrote:<br></div><div>[-- Type: text/plain; charset=utf-8, Encoding: quoted-printable, Size: 7.6K --]<br></div><blockquote class="ws-ng-quote"><div> On 2025-01-19T13:31:40.000+01:00, Pietro Cerutti <<a class="defaultMailLink" href="mailto:gahr@FreeBSD.org">gahr@FreeBSD.org</a>><br></div><div>wrote:<br></div><div><br></div><blockquote class="ws-ng-quote"><div> The branch main has been updated by gahr:<br></div><div> <br></div><div> URL: <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://cgit.FreeBSD.org/ports/commit/?id=98582ae673d871b51f1c0b6b7cafb35879c02efc" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=98582ae673d871b51f1c0b6b7cafb35879c02efc</a><br></div><div>; <br></div><div> commit 98582ae673d871b51f1c0b6b7cafb35879c02efc<br></div><div> <br></div><div> Author: Pietro Cerutti <<a class="defaultMailLink" href="mailto:gahr@FreeBSD.org">gahr@FreeBSD.org</a>><br></div><div> <br></div><div> AuthorDate: 2025-01-19 12:25:14 +0000<br></div><div> <br></div><div> Commit: Pietro Cerutti <<a class="defaultMailLink" href="mailto:gahr@FreeBSD.org">gahr@FreeBSD.org</a>><br></div><div> <br></div><div> CommitDate: 2025-01-19 12:31:27 +0000<br></div><div> <br></div><div> mail/opensmtpd-table-sqlite: new port<br></div><div> <br></div><div> <br></div><div> <br></div><div> This port replaces mail/opensmtpd-extras-table-sqlite.<br></div><div> <br></div><div> <br></div><div> <br></div><div> The opensmtpd-extras-table-* ports got broken by the latest update of<br></div><div> <br></div><div> OpenSMTPD, see my message on the mailing list:<br></div><div> <br></div><div> <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://lists.freebsd.org/archives/dev-commits-ports-main/2025-January/134537.html" target="_blank">https://lists.freebsd.org/archives/dev-commits-ports-main/2025-January/134537.html</a><br></div><div>; <br></div><div> <br></div><div> <br></div><div> I have requested action by fluffy@ both on the message linked above and<br></div><div> <br></div><div> privately via email, but I haven't got any response back.<br></div><div> <br></div><div> <br></div><div> <br></div><div> At this point, I want to unblock my workflow and be able to upgrade<br></div><div> <br></div><div> OpenSMTPD. I don't have plans to provide alternatives to all the<br></div><div> <br></div><div> opensmtpd-extras-table-* ports.<br></div><div> <br></div><div> ---<br></div><div> <br></div><div> mail/Makefile | 1 +<br></div><div> <br></div><div> mail/opensmtpd-table-sqlite/Makefile | 26 ++++++++++++++++++++++++++<br></div><div> <br></div><div> mail/opensmtpd-table-sqlite/distinfo | 5 +++++<br></div><div> <br></div><div> mail/opensmtpd-table-sqlite/pkg-descr | 2 ++<br></div><div> <br></div><div> 4 files changed, 34 insertions(+)<br></div><div> <br></div><div> diff --git a/mail/Makefile b/mail/Makefile<br></div><div> <br></div><div> index 7fc7b579932a..09a72821dd5f 100644<br></div><div> <br></div><div> --- a/mail/Makefile<br></div><div> <br></div><div> +++ b/mail/Makefile<br></div><div> <br></div><div> @@ -290,6 +290,7 @@<br></div><div> <br></div><div> SUBDIR += opensmtpd-extras-table-sqlite<br></div><div> <br></div><div> SUBDIR += opensmtpd-filter-rspamd<br></div><div> <br></div><div> SUBDIR += opensmtpd-filter-senderscore<br></div><div> <br></div><div> + SUBDIR += opensmtpd-table-sqlite<br></div><div> <br></div><div> SUBDIR += osbf-lua<br></div><div> <br></div><div> SUBDIR += ovs<br></div><div> <br></div><div> SUBDIR += p5-CGP-CLI<br></div><div> <br></div><div> diff --git a/mail/opensmtpd-table-sqlite/Makefile b/mail/opensmtpd-table-sqlite/Makefile<br></div><div> <br></div><div> new file mode 100644<br></div><div> <br></div><div> index 000000000000..dfd64f7c1ecf<br></div><div> <br></div><div> --- /dev/null<br></div><div> <br></div><div> +++ b/mail/opensmtpd-table-sqlite/Makefile<br></div><div> <br></div><div> @@ -0,0 +1,26 @@<br></div><div> <br></div><div> +PORTNAME= opensmtpd-table-sqlite<br></div><div> <br></div><div> +DISTVERSION= 1.0.1<br></div><div> <br></div><div> +CATEGORIES= mail<br></div><div> <br></div><div> +<br></div><div> <br></div><div> +PATCH_SITES= <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://github.com/OpenSMTPD/table-sqlite/commit/" target="_blank">https://github.com/OpenSMTPD/table-sqlite/commit/</a><br></div><div>; <br></div><div> +PATCHFILES= f3c46da1cbbb2a9d32cd9b4cf31e9fdb5b941a16.patch:-p1<br></div><div> <br></div><div> +<br></div><div> <br></div><div> +MAINTAINER= <a class="defaultMailLink" href="mailto:gahr@FreeBSD.org">gahr@FreeBSD.org</a><br></div><div> <br></div><div> +COMMENT= SQLite table for OpenSMTPD<br></div><div> <br></div><div> +WWW= <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://github.com/opensmtpd/table-sqlite" target="_blank">https://github.com/opensmtpd/table-sqlite</a><br></div><div>; <br></div><div> +<br></div><div> <br></div><div> +LICENSE= ISCL<br></div><div> <br></div><div> +<br></div><div> <br></div><div> +USES= autoreconf localbase sqlite<br></div><div> <br></div><div> +GNU_CONFIGURE= yes<br></div><div> <br></div><div> +<br></div><div> <br></div><div> +PATCH_ARGS= -p1<br></div><div> <br></div><div> +<br></div><div> <br></div><div> +USE_GITHUB= yes<br></div><div> <br></div><div> +GH_ACCOUNT= opensmtpd<br></div><div> <br></div><div> +GH_PROJECT= table-sqlite<br></div><div> <br></div><div> +<br></div><div> <br></div><div> +PLIST_FILES= libexec/smtpd/table-sqlite \<br></div><div> <br></div><div> + share/man/man5/table-sqlite.5.gz<br></div><div> <br></div><div> +<br></div><div> <br></div><div> +.include <<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://bsd.port.mk>" target="_blank">bsd.port.mk></a>; [<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="http://bsd.port.mk>" target="_blank">http://bsd.port.mk></a>;];<br></div><div>; <br></div><div> diff --git a/mail/opensmtpd-table-sqlite/distinfo b/mail/opensmtpd-table-sqlite/distinfo<br></div><div> <br></div><div> new file mode 100644<br></div><div> <br></div><div> index 000000000000..f19d8caf3cda<br></div><div> <br></div><div> --- /dev/null<br></div><div> <br></div><div> +++ b/mail/opensmtpd-table-sqlite/distinfo<br></div><div> <br></div><div> @@ -0,0 +1,5 @@<br></div><div> <br></div><div> +TIMESTAMP = 1737289442<br></div><div> <br></div><div> +SHA256 (opensmtpd-table-sqlite-1.0.1_GH0.tar.gz) = 74f40788aec40087235cb82391ad21ed4aeb6d79dd7a0e89571f398825b653b0<br></div><div> <br></div><div> +SIZE (opensmtpd-table-sqlite-1.0.1_GH0.tar.gz) = 21718<br></div><div> <br></div><div> +SHA256 (f3c46da1cbbb2a9d32cd9b4cf31e9fdb5b941a16.patch) = 0256ee0d826543e4ae4263f05c6ddedc635f72a713f34592663e4dbdd40e6d6c<br></div><div> <br></div><div> +SIZE (f3c46da1cbbb2a9d32cd9b4cf31e9fdb5b941a16.patch) = 1552<br></div><div> <br></div><div> diff --git a/mail/opensmtpd-table-sqlite/pkg-descr b/mail/opensmtpd-table-sqlite/pkg-descr<br></div><div> <br></div><div> new file mode 100644<br></div><div> <br></div><div> index 000000000000..ede5705d7728<br></div><div> <br></div><div> --- /dev/null<br></div><div> <br></div><div> +++ b/mail/opensmtpd-table-sqlite/pkg-descr<br></div><div> <br></div><div> @@ -0,0 +1,2 @@<br></div><div> <br></div><div> +The SQLite table addon for OpenSMTPD allows the storing of usernames,<br></div><div> <br></div><div> +passwords, aliases, and domains in a sqlite3 table.<br></div></blockquote><div> <br></div><div>Hi,<br></div><div><br></div><div>Any reason why you're not using upstream's release archive?<br></div><div><br></div><div>That gets rid of patching and USES= autoreconf and you probably also<br></div><div>want USES= localbase:ldflags instead of localbase . Looking at Porters<br></div><div>Handbook you should likely also make use of PKGNAMEPREFIX instead of<br></div><div>having opensmtpd- in PORTNAME.<br></div></blockquote><div> <br></div><div>Using the release archive won't make the patch useless. Localbase is <br></div><div>enough, no need for ldflags. I don't see the point of using <br></div><div>PKGNAMEPREFIX.<br></div><div><br></div><blockquote class="ws-ng-quote"> PATCH_ARGS is also unnecessary as you've set -p1 already.<br></blockquote><div> <br></div><div>True, I'll do it when I need to commit the port next.<br></div><div><br></div><div><br></div><div>-- <br></div><div>Pietro Cerutti<br></div><div>I have pledged to give 10% of income to effective charities<br></div><div>and invite you to join me - <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://givingwhatwecan.org" target="_blank">https://givingwhatwecan.org</a><br></div></pre></blockquote></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Hi,<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">You don't need the patch as it's already applied?<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">As for LDLAGS vs LIBS, the configure script itself mentions that LDFLAGS should be used for the specific fix?<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">"LDFLAGS linker flags, e.g. -L<lib dir> if you have libraries in a nonstandard directory <lib dir>"<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">vs<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">"LIBS libraries to pass to the linker, e.g. -l<library>"<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Using PKGNAMEPREFIX avoids you hacking around upstream's project name in ports.<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Best regards,<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Daniel<br></div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0cfa09977d44f4345dc26dfc3b29dd34>