Date: 19 Jan 2002 11:42:43 -0500 From: Joe Clarke <marcus@marcuscom.com> To: Anders Andersson <anders@hack.org> Cc: gnome@FreeBSD.ORG Subject: Re: deskutils/gnomepim Message-ID: <1011458564.62255.3.camel@shumai.marcuscom.com> In-Reply-To: <20020119162813.GA25897@sushi.sanyusan.se> References: <20020119162813.GA25897@sushi.sanyusan.se>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-BB87yMWvX6vsxqjtg3yd
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
On Sat, 2002-01-19 at 11:28, Anders Andersson wrote:
> It seems that the expected result is inverted in gnomepim's Makefile.
>
> If I define WITHOUT_PILOT then it builds gnomepim with pilot support and
> if I dont define WITHOUT_PILOT it happily builds without pilot-link and
> so on.
>
> I will look at the Makefile to see if I have missed a studpid tweak or
> not.
You're absolutely right. The Makefile should read:
.if !defined(WITHOUT_PILOT)
BUILD_DEPENDS=
${X11BASE}/lib/gnome-pilot/conduits/libemail_conduit.so:${PORTSDIR}/palm/gnomepilot-conduits
RUN_DEPENDS=
${X11BASE}/lib/gnome-pilot/conduits/libemail_conduit.so:${PORTSDIR}/palm/gnomepilot-conduits
.endif
But instead will add the depends when you _do_ define WITHOUT_PILOT. Of
course, it goes on to do the right thing in other places, so this may
break the port.
The attached patch should fix things.
Joe
>
> --
> Anders Andersson <anders@hack.org>
> UNIX, Networking and Security consultant
> +46 (0)705 87 53 35
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-gnome" in the body of the message
>
--=-BB87yMWvX6vsxqjtg3yd
Content-Disposition: attachment; filename=Makefile.patch
Content-Transfer-Encoding: quoted-printable
Content-Type: text/x-makefile; charset=ISO-8859-1
--- Makefile.orig Sat Jan 19 11:40:59 2002
+++ Makefile Sat Jan 19 11:41:24 2002
@@ -15,7 +15,7 @@
=20
MAINTAINER=3D gnome@FreeBSD.org
=20
-.if defined(WITHOUT_PILOT)
+.if !defined(WITHOUT_PILOT)
BUILD_DEPENDS=3D ${X11BASE}/lib/gnome-pilot/conduits/libemail_conduit.so:$=
{PORTSDIR}/palm/gnomepilot-conduits
RUN_DEPENDS=3D ${X11BASE}/lib/gnome-pilot/conduits/libemail_conduit.so:${P=
ORTSDIR}/palm/gnomepilot-conduits
.endif
--=-BB87yMWvX6vsxqjtg3yd--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-gnome" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1011458564.62255.3.camel>