Date: 27 Nov 2002 11:37:04 +0000 From: Doug Rabson <dfr@nlsystems.com> To: Warner Losh <imp@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys rman.h src/sys/kern subr_rman.c Message-ID: <1038397024.8963.1.camel@builder02.qubesoft.com> In-Reply-To: <200211270355.gAR3tMQh036625@repoman.freebsd.org> References: <200211270355.gAR3tMQh036625@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2002-11-27 at 03:55, Warner Losh wrote:
> imp 2002/11/26 19:55:22 PST
>
> Modified files:
> sys/sys rman.h
> sys/kern subr_rman.c
> Log:
> Make the rman_{get,set}_* macros into real functions. The macros
> create an ABI that encodes offsets and sizes of structures into client
> drivers. The functions isolate the ABI from changes to the resource
> structure. Since these are used very rarely (once at startup), the
> speed penalty will be down in the noise.
>
> Also, add r_rid to the structure so that clients can save the 'rid' of
> the resource in the struct resource, plus accessor functions. Future
> additions to newbus will make use of this to present a simplified
> interface for resource specification.
Can you move the structures out of the public header file now? I
originally wanted to hide the structures inside the implementation but
Garret wanted to allow direct access to the structures, I seem to
remember. The macros were a compromise.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1038397024.8963.1.camel>