Date: Fri, 02 Mar 2012 12:38:44 -0800 From: Sean Bruno <seanbru@yahoo-inc.com> To: hackers@freebsd.org Subject: [patch] Disable bios probe if acpi is enabled Message-ID: <1330720724.5391.2.camel@powernoodle-l7.corp.yahoo.com>
next in thread | raw e-mail | index | archive | help
--=-fBr89LSh/s3j85QKJKm1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
I'm noting that newer machines are completely hosed if we attempt to
probe for bios values. I'm proposing this change.
-bash-4.2$ p4 diff -du //depot/yahoo/ybsd_7/src/sys/i386/i386/bios.c
--- //depot/yahoo/ybsd_7/src/sys/i386/i386/bios.c 2011-09-16
22:47:30.000000000 0000
+++ /home/seanbru/ybsd_7/src/sys/i386/i386/bios.c 2011-09-16
22:47:30.000000000 0000
@@ -84,6 +84,12 @@
char *p;
=20
/*
+ * Don't do bios probing if acpi is enabled, its
+ * pointless and breaks on newer systems
+ */
+ if (!resource_disabled("acpi", 0))
+ return;
+ /*
* BIOS32 Service Directory, PCI BIOS
*/
--=-fBr89LSh/s3j85QKJKm1
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)
iQEcBAABAgAGBQJPUS/UAAoJEL2UHwafTLtO5iYH/1C0Rpfo1UHFHnhn0G7qHscl
WJGeScyGo3UaMuqUIHYJV/HEYirzUxCfzG6xYC6ple1OMAb6zfGqCapB2NnIQSgn
JcnQKImsfdyrw6y/iyO+0vPm3GghI4qC5zokT1khvdGjf1hK1TOIEshJ5+jg08bn
wxQEvM9js6aunEq1POpYd0fgpa+H3UTv2/uYTi/5lk4pCth8c22ZGb1I644RkOj+
/7wP2LPLCpWOw6g7jqQ50o3CyQgaeo3cMh8LUVFvkd0L4txjyeuOd/ErRZf12u9x
DMVErsYcGGAhhEPdS2MQCMZXjxgnpdCIiz24tqsqHMjXTeviD6YkZM7aMEeVTkc=
=N1u9
-----END PGP SIGNATURE-----
--=-fBr89LSh/s3j85QKJKm1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1330720724.5391.2.camel>